Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

railjson_generator: disable route creation between two buffer stops #3844

Merged
merged 1 commit into from
Apr 7, 2023
Merged

railjson_generator: disable route creation between two buffer stops #3844

merged 1 commit into from
Apr 7, 2023

Conversation

flomonster
Copy link
Contributor

No description provided.

@flomonster flomonster marked this pull request as ready for review April 7, 2023 09:35
@flomonster flomonster requested a review from a team as a code owner April 7, 2023 09:35
Khoyo
Khoyo approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as discussed.

Khoyo
Khoyo requested changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait. This removes every route that start and stop at a buffer stop. We need to remove routes that don't see a signal, not routes that simply go from buffer stop to buffer stop

Khoyo
Khoyo approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved again after discussion with @multun. This is weird edgecase anyway, it shouldn't ever happen on a real infra

@flomonster flomonster merged commit 31f674b into dev Apr 7, 2023
@flomonster flomonster deleted the fam/fix-generator-infra branch April 7, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khoyo Khoyo Khoyo approved these changes

@Tguisnet Tguisnet Tguisnet approved these changes

@Castavo Castavo Castavo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flomonster @Khoyo @Tguisnet @Castavo