Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: remove electrical profile set from scenario patch form #3916

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

younesschrifi
Copy link
Contributor

Close #3784

@younesschrifi younesschrifi requested a review from a team as a code owner April 14, 2023 09:29
@younesschrifi younesschrifi force-pushed the yci/fix-patch-scenario branch from 0e70530 to 4cdfe8a Compare April 14, 2023 09:30
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #3916 (41a8319) into dev (32c4965) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff            @@
##                dev    #3916   +/-   ##
=========================================
  Coverage     69.69%   69.69%           
  Complexity     2027     2027           
=========================================
  Files           439      439           
  Lines         22242    22246    +4     
  Branches       1672     1672           
=========================================
+ Hits          15501    15504    +3     
- Misses         5937     5938    +1     
  Partials        804      804           
Flag Coverage Δ
editoast 74.02% <ø> (-0.04%) ⬇️
front 59.29% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/views/scenario.rs 95.29% <ø> (-0.06%) ⬇️
front/src/common/api/osrdEditoastApi.ts 91.47% <85.71%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@younesschrifi younesschrifi marked this pull request as draft April 14, 2023 09:48
@younesschrifi younesschrifi marked this pull request as ready for review April 14, 2023 10:59
@younesschrifi younesschrifi requested a review from a team as a code owner April 14, 2023 10:59
@flomonster flomonster force-pushed the yci/fix-patch-scenario branch from 4488d71 to 208938f Compare April 18, 2023 07:36
@younesschrifi younesschrifi force-pushed the yci/fix-patch-scenario branch from 208938f to 41a8319 Compare April 18, 2023 09:05
@younesschrifi younesschrifi merged commit 2b73ce4 into dev Apr 18, 2023
@younesschrifi younesschrifi deleted the yci/fix-patch-scenario branch April 18, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong behavior with scenario patch endpoint
4 participants