Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: add delete endpoint to rollingstock api #4044

Merged
merged 1 commit into from
May 11, 2023
Merged

editoast: add delete endpoint to rollingstock api #4044

merged 1 commit into from
May 11, 2023

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented May 4, 2023 •
edited by clarani
Loading

closes #3995

@Erashin Erashin requested a review from a team as a code owner May 4, 2023 06:21
@Erashin Erashin force-pushed the osrd_3995/editoast/add_delete_endpoint_rollingstock branch 2 times, most recently from 7dfc4fb to 68e61c3 Compare May 4, 2023 06:42
@codecov
Copy link

codecov bot commented May 4, 2023 •
edited
Loading

Codecov Report

Merging #4044 (d334d5b) into dev (a80f665) will increase coverage by 49.58%.
The diff coverage is 100.00%.

❗ Current head d334d5b differs from pull request most recent head 96a4c09. Consider uploading reports for the commit 96a4c09 to get more accurate results

@@              Coverage Diff              @@
##                dev    #4044       +/-   ##
=============================================
+ Coverage     20.26%   69.84%   +49.58%     
+ Complexity     2080     2073        -7     
=============================================
  Files           799      444      -355     
  Lines         78788    22725    -56063     
  Branches       2070     1706      -364     
=============================================
- Hits          15968    15873       -95     
+ Misses        61648     6044    -55604     
+ Partials       1172      808      -364
Flag Coverage Δ
editoast 73.93% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/views/rolling_stocks.rs 53.38% <100.00%> (+2.98%) ⬆️
front/src/common/api/osrdEditoastApi.ts 91.40% <100.00%> (+0.13%) ⬆️

... and 369 files with indirect coverage changes

@Erashin Erashin force-pushed the osrd_3995/editoast/add_delete_endpoint_rollingstock branch 4 times, most recently from f20368d to 7457141 Compare May 4, 2023 08:42
@Erashin Erashin added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service component:rollingstock work related to rollingstock definitions kind:feature-task Work related to a feature epic module:rollingstocks-editor A module dedicated to rollingstock editors and removed area:front Work on Standard OSRD Interface modules labels May 5, 2023
@Erashin Erashin force-pushed the osrd_3995/editoast/add_delete_endpoint_rollingstock branch from 7457141 to dfec522 Compare May 5, 2023 08:02
leovalais
leovalais requested changes May 5, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few things:

@Erashin Erashin force-pushed the osrd_3995/editoast/add_delete_endpoint_rollingstock branch 2 times, most recently from 1bfeb7d to 99bcca8 Compare May 5, 2023 09:32
@Erashin Erashin force-pushed the osrd_3995/editoast/add_delete_endpoint_rollingstock branch 3 times, most recently from 73d6b6e to 2cb97c5 Compare May 10, 2023 14:30
@flomonster flomonster force-pushed the osrd_3995/editoast/add_delete_endpoint_rollingstock branch from 2cb97c5 to 201404b Compare May 11, 2023 07:55
flomonster
flomonster approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this PR.

@flomonster flomonster force-pushed the osrd_3995/editoast/add_delete_endpoint_rollingstock branch from 201404b to 3ade671 Compare May 11, 2023 08:29
@Erashin Erashin force-pushed the osrd_3995/editoast/add_delete_endpoint_rollingstock branch from 3ade671 to 04fdceb Compare May 11, 2023 08:58
@Erashin Erashin force-pushed the osrd_3995/editoast/add_delete_endpoint_rollingstock branch from 04fdceb to 96a4c09 Compare May 11, 2023 09:32
@Erashin Erashin merged commit 9c5560e into dev May 11, 2023
@Erashin Erashin deleted the osrd_3995/editoast/add_delete_endpoint_rollingstock branch May 11, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

@leovalais leovalais leovalais approved these changes

Assignees
No one assigned
Labels
area:editoast Work on Editoast Service component:rollingstock work related to rollingstock definitions kind:feature-task Work related to a feature epic module:rollingstocks-editor A module dedicated to rollingstock editors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DELETE to rollingStock upsert Payload API
3 participants
@Erashin @flomonster @leovalais