Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add a osm-to-railjson command #4048

Merged
merged 2 commits into from
May 10, 2023
Merged

editoast: add a osm-to-railjson command #4048

merged 2 commits into from
May 10, 2023

Conversation

Tristramg
Copy link
Contributor

This command will extract data from OpenStreetMap (.pbf file format) and generate the track_sections from Ways that represent rails

It uses the osm4routing crate to cut the ways into edges suitable for routing

ref #4035

@Tristramg Tristramg requested a review from a team as a code owner May 4, 2023 13:38
@Tristramg Tristramg changed the title Add a osm-to-railjson command editoast: add a osm-to-railjson command May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #4048 (a830b71) into dev (e15428a) will increase coverage by 0.01%.
The diff coverage is 83.33%.

❗ Current head a830b71 differs from pull request most recent head 33f8a8e. Consider uploading reports for the commit 33f8a8e to get more accurate results

@@             Coverage Diff              @@
##                dev    #4048      +/-   ##
============================================
+ Coverage     20.23%   20.24%   +0.01%     
+ Complexity     2076     2073       -3     
============================================
  Files           795      795              
  Lines         78377    78394      +17     
  Branches       2058     2057       -1     
============================================
+ Hits          15858    15872      +14     
- Misses        61359    61363       +4     
+ Partials       1160     1159       -1     
Flag Coverage Δ
editoast 73.92% <83.33%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/client/mod.rs 100.00% <ø> (ø)
editoast/src/main.rs 10.11% <0.00%> (-0.13%) ⬇️
editoast/src/converters/osm_to_railjson.rs 88.23% <88.23%> (ø)

... and 3 files with indirect coverage changes

@Tristramg Tristramg marked this pull request as draft May 9, 2023 07:08
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 🎉
It looks good to me, can you just rewrite your git history to follow up the git commit style describe here.

@Tristramg Tristramg force-pushed the osm_to_railjson branch 2 times, most recently from 6169782 to f75fd1a Compare May 9, 2023 11:27
@Tristramg Tristramg marked this pull request as ready for review May 9, 2023 11:47
Tristramg added 2 commits May 9, 2023 20:59
This command will extract data from OpenStreetMap (.pbf file format)
and generate the track_sections from Ways that represent rails

It uses the osm4routing crate to cut the ways into edges suitable for
routing

So far it only handles track sections
@Tristramg Tristramg merged commit a846d00 into dev May 10, 2023
@Tristramg Tristramg deleted the osm_to_railjson branch May 10, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants