Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signals angle #4068

Merged
merged 4 commits into from
May 17, 2023
Merged

Fix signals angle #4068

merged 4 commits into from
May 17, 2023

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented May 9, 2023 •
edited
Loading

close #2948

signals

@codecov
Copy link

codecov bot commented May 9, 2023 •
edited
Loading

Codecov Report

Merging #4068 (5bf020d) into dev (c0841c4) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 5bf020d differs from pull request most recent head 2878101. Consider uploading reports for the commit 2878101 to get more accurate results

@@            Coverage Diff            @@
##                dev    #4068   +/-   ##
=========================================
  Coverage     20.30%   20.31%           
  Complexity     2007     2007           
=========================================
  Files           815      815           
  Lines         80471    80452   -19     
  Branches       2088     2088           
=========================================
+ Hits          16341    16345    +4     
+ Misses        62943    62920   -23     
  Partials       1187     1187
Flag Coverage Δ
front 8.56% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/models/infra.rs 82.85% <ø> (ø)
editoast/src/schema/signal.rs 76.92% <ø> (ø)
...ications/editor/tools/pointEdition/tool-factory.ts 0.00% <ø> (ø)
front/src/common/Map/Layers/geoSignalsLayers.ts 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@flomonster flomonster force-pushed the fam/editoast-fix-signals-angle branch 4 times, most recently from 8546659 to f982bd8 Compare May 16, 2023 16:07
@flomonster flomonster marked this pull request as ready for review May 16, 2023 16:07
@flomonster flomonster requested review from a team as code owners May 16, 2023 16:07
@flomonster flomonster force-pushed the fam/editoast-fix-signals-angle branch 2 times, most recently from 73c2d24 to aab0df4 Compare May 17, 2023 08:56
@flomonster flomonster requested a review from leovalais May 17, 2023 09:30
flomonster added 4 commits May 17, 2023 16:58
@flomonster
api: remove signal angles
d726b89 
Patch notes railjson 3.2.1:

- Remove `geo_angles` and `sch_angles` from the signal sncf extension
@flomonster
editoast: adapt to the new railjson 3.2.1 format
54c41b0 
- Adapt schema
- Generate signal angle
- Adapt the signal mvt layer
@flomonster
railjson_generator: adapt to the new railjson 3.2.1 schema
309ac47
@flomonster
front: adapt to the new layer get angle directly
2878101
@flomonster flomonster force-pushed the fam/editoast-fix-signals-angle branch from aab0df4 to 2878101 Compare May 17, 2023 14:58
leovalais
leovalais approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested by changing manually the angle of a signal.

@flomonster flomonster merged commit 15f05d1 into dev May 17, 2023
@flomonster flomonster deleted the fam/editoast-fix-signals-angle branch May 17, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

@leovalais leovalais leovalais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove angle from signals and generate it from editoast
3 participants
@flomonster @nicolaswurtz @leovalais