Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: one click to select projects, one click to delete them, and in the darkness bind them #4125

Merged
merged 5 commits into from
Jun 28, 2023

Conversation

nicolaswurtz
Copy link
Contributor

No description provided.

@nicolaswurtz nicolaswurtz force-pushed the nwz/mass-delete-with-ctrl-shift branch from d986d3c to 064f2b1 Compare May 15, 2023 12:28
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #4125 (5abfa9a) into dev (9dfa431) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #4125      +/-   ##
============================================
- Coverage     22.38%   22.34%   -0.04%     
  Complexity     2314     2314              
============================================
  Files           867      869       +2     
  Lines         85606    85750     +144     
  Branches       2243     2245       +2     
============================================
  Hits          19159    19159              
- Misses        65220    65362     +142     
- Partials       1227     1229       +2     
Flag Coverage Δ
front 10.24% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/applications/operationalStudies/Home.tsx 0.00% <0.00%> (ø)
...nalStudies/components/Home/DeleteProjectsModal.tsx 0.00% <0.00%> (ø)
...operationalStudies/components/Home/ProjectCard.tsx 0.00% <0.00%> (ø)
...tudies/components/Home/ProjectSelectionToolbar.tsx 0.00% <0.00%> (ø)
...perationalStudies/components/Project/StudyCard.tsx 0.00% <0.00%> (ø)
...erationalStudies/components/Study/ScenarioCard.tsx 0.00% <0.00%> (ø)
.../applications/operationalStudies/views/Project.tsx 0.00% <0.00%> (ø)
...rc/applications/operationalStudies/views/Study.tsx 0.00% <0.00%> (ø)

@nicolaswurtz nicolaswurtz force-pushed the nwz/mass-delete-with-ctrl-shift branch 3 times, most recently from b13a363 to 0a2b55a Compare May 24, 2023 08:44
@nicolaswurtz nicolaswurtz force-pushed the nwz/mass-delete-with-ctrl-shift branch 2 times, most recently from 99fef7d to 88995e3 Compare June 8, 2023 08:00
@nicolaswurtz nicolaswurtz force-pushed the nwz/mass-delete-with-ctrl-shift branch from 88995e3 to 3e183c6 Compare June 28, 2023 05:04
@nicolaswurtz nicolaswurtz changed the title front: mass delete with ctrl shift front: one click to select projects, one click to delete them, and in the darkness bind them Jun 28, 2023
@nicolaswurtz nicolaswurtz marked this pull request as ready for review June 28, 2023 05:37
@nicolaswurtz nicolaswurtz requested review from eckter and a team as code owners June 28, 2023 05:37
@nicolaswurtz nicolaswurtz removed the request for review from eckter June 28, 2023 05:55
@nicolaswurtz nicolaswurtz force-pushed the nwz/mass-delete-with-ctrl-shift branch from 8336a55 to 5b3da2d Compare June 28, 2023 05:55
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, it will be useful ! Any chance you could add the corresponding and missing e2e test for the multiple selection and deletion of projects ?

@anisometropie
Copy link
Contributor

anisometropie commented Jun 28, 2023

7qu0b8

@nicolaswurtz nicolaswurtz force-pushed the nwz/mass-delete-with-ctrl-shift branch from 3398bd1 to 5abfa9a Compare June 28, 2023 09:15
@nicolaswurtz
Copy link
Contributor Author

Thanks for that, it will be useful ! Any chance you could add the corresponding and missing e2e test for the multiple selection and deletion of projects ?

Yes, it would be great, but not now if possible... :D

@nicolaswurtz nicolaswurtz added this pull request to the merge queue Jun 28, 2023
Merged via the queue into dev with commit 1f043d1 Jun 28, 2023
@nicolaswurtz nicolaswurtz deleted the nwz/mass-delete-with-ctrl-shift branch June 28, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants