-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix track edition and change http code on unknwon objet id #4305
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4305 +/- ##
=========================================
Coverage 21.70% 21.70%
Complexity 2194 2194
=========================================
Files 843 843
Lines 83671 83678 +7
Branches 2178 2178
=========================================
+ Hits 18164 18166 +2
- Misses 64305 64310 +5
Partials 1202 1202
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7ef4dfe
to
3d85063
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix :) Successfully tested.
Just maybe in tools.tsx, fix the import not used and the indent warnings
3d85063
to
c907807
Compare
c907807
to
94aa32a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't tested in local, but @SharglutDev did and I corrected the bug with @Castavo
closes: #4171