Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track edition and change http code on unknwon objet id #4305

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Jun 7, 2023

closes: #4171

@Castavo Castavo requested review from a team as code owners June 7, 2023 13:33
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #4305 (c907807) into dev (ce68102) will increase coverage by 0.00%.
The diff coverage is 31.25%.

@@            Coverage Diff            @@
##                dev    #4305   +/-   ##
=========================================
  Coverage     21.70%   21.70%           
  Complexity     2194     2194           
=========================================
  Files           843      843           
  Lines         83671    83678    +7     
  Branches       2178     2178           
=========================================
+ Hits          18164    18166    +2     
- Misses        64305    64310    +5     
  Partials       1202     1202           
Flag Coverage Δ
editoast 69.40% <41.66%> (-0.07%) ⬇️
front 9.87% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/schema/operation/delete.rs 50.00% <0.00%> (-8.34%) ⬇️
editoast/src/schema/operation/mod.rs 45.45% <ø> (ø)
...t/src/applications/editor/tools/selection/tool.tsx 0.00% <0.00%> (ø)
editoast/src/schema/operation/update.rs 75.00% <55.55%> (-2.28%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Castavo Castavo force-pushed the bpt/fix/track-edition branch from 7ef4dfe to 3d85063 Compare June 8, 2023 08:24
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix :) Successfully tested.
Just maybe in tools.tsx, fix the import not used and the indent warnings

@Castavo Castavo force-pushed the bpt/fix/track-edition branch from 3d85063 to c907807 Compare June 13, 2023 16:13
@Castavo Castavo force-pushed the bpt/fix/track-edition branch from c907807 to 94aa32a Compare June 14, 2023 08:45
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't tested in local, but @SharglutDev did and I corrected the bug with @Castavo

@Castavo Castavo enabled auto-merge June 14, 2023 08:54
@Castavo Castavo added this pull request to the merge queue Jun 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 14, 2023
@Castavo Castavo added this pull request to the merge queue Jun 14, 2023
Merged via the queue into dev with commit 0d7faae Jun 14, 2023
@Castavo Castavo deleted the bpt/fix/track-edition branch June 14, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit a track section fails
5 participants