Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add search criteria "ch" for operational points #4406

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

leovalais
Copy link
Contributor

For PTO import.

@leovalais leovalais added the area:editoast Work on Editoast Service label Jun 21, 2023
@leovalais leovalais requested a review from a team as a code owner June 21, 2023 14:46
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #4406 (8280844) into dev (6328186) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                dev    #4406   +/-   ##
=========================================
  Coverage     22.35%   22.35%           
  Complexity     2301     2301           
=========================================
  Files           849      849           
  Lines         85798    85802    +4     
  Branches       2238     2238           
=========================================
+ Hits          19182    19184    +2     
- Misses        65388    65390    +2     
  Partials       1228     1228           
Flag Coverage Δ
editoast 70.15% <ø> (-0.04%) ⬇️
front 10.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/common/api/osrdEditoastApi.ts 91.63% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

@leovalais leovalais force-pushed the lva/add-search-op-ch branch 2 times, most recently from 8bef302 to f0a61b5 Compare June 21, 2023 15:14
Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The openapi should be adapted.

@leovalais leovalais force-pushed the lva/add-search-op-ch branch 3 times, most recently from 4804a25 to 92bb348 Compare June 22, 2023 13:12
@leovalais leovalais enabled auto-merge June 28, 2023 08:45
@leovalais leovalais force-pushed the lva/add-search-op-ch branch from 92bb348 to 8280844 Compare June 29, 2023 12:28
@leovalais leovalais added this pull request to the merge queue Jun 29, 2023
Merged via the queue into dev with commit 6d38dfa Jun 29, 2023
@leovalais leovalais deleted the lva/add-search-op-ch branch June 29, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants