Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: import - autocomplete pathfings with waypoints #4422

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jun 23, 2023

closes #4129
closes #4130

New ImportTrainScheduleModal:
image

@clarani clarani requested review from a team as code owners June 23, 2023 08:32
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #4422 (d2674ba) into dev (86368db) will decrease coverage by 0.07%.
The diff coverage is 1.84%.

❗ Current head d2674ba differs from pull request most recent head af9cf92. Consider uploading reports for the commit af9cf92 to get more accurate results

@@             Coverage Diff              @@
##                dev    #4422      +/-   ##
============================================
- Coverage     19.93%   19.87%   -0.07%     
+ Complexity     2323     2316       -7     
============================================
  Files           865      868       +3     
  Lines         88182    88331     +149     
  Branches       2280     2280              
============================================
- Hits          17583    17558      -25     
- Misses        69341    69514     +173     
- Partials       1258     1259       +1     
Flag Coverage Δ
front 9.43% <1.84%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ImportTrainSchedule/ImportTrainScheduleConfig.tsx 0.00% <0.00%> (ø)
...s/ImportTrainSchedule/ImportTrainScheduleModal.jsx 0.00% <0.00%> (ø)
...ainSchedule/ImportTrainScheduleStationSelector.jsx 0.00% <0.00%> (ø)
...rtTrainSchedule/ImportTrainScheduleTrainDetail.tsx 0.00% <0.00%> (ø)
...ortTrainSchedule/ImportTrainScheduleTrainsList.tsx 0.00% <0.00%> (ø)
...lStudies/components/ImportTrainSchedule/consts.jsx 0.00% <ø> (ø)
...ImportTrainSchedule/generatePathfindingPayload.jsx 0.00% <0.00%> (ø)
front/src/applications/operationalStudies/types.ts 0.00% <0.00%> (ø)
...s/operationalStudies/views/ImportTrainSchedule.tsx 0.00% <0.00%> (ø)
...applications/operationalStudies/views/Scenario.tsx 0.00% <0.00%> (ø)
... and 4 more

... and 13 files with indirect coverage changes

@clarani clarani force-pushed the lagg/pathfinding-import-migration branch 4 times, most recently from 7c6ede8 to ece9985 Compare June 23, 2023 15:50
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nicolaswurtz nicolaswurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, we can't adapt OSRD to my project, and we can't name my project inside code. We'll have to discuss about this, no worry ;)

@clarani clarani force-pushed the lagg/pathfinding-import-migration branch from ece9985 to 0a817a4 Compare July 13, 2023 10:25
@multun multun force-pushed the lagg/pathfinding-import-migration branch from b2b05c4 to 15d4c52 Compare July 18, 2023 09:00
@multun multun requested review from a team, eckter, flomonster and multun as code owners July 18, 2023 09:00
@clarani clarani removed request for a team, eckter, multun and flomonster July 18, 2023 09:47
@clarani clarani force-pushed the lagg/pathfinding-import-migration branch from b79e97c to 2523da1 Compare July 18, 2023 12:27
@clarani clarani force-pushed the lagg/pathfinding-import-migration branch from 1aaa639 to d2674ba Compare July 20, 2023 12:13
@anisometropie
Copy link
Contributor

#4633

use steps' uic to generate waypoints and automatically generate pathfindings with the waypoints
@clarani clarani force-pushed the lagg/pathfinding-import-migration branch from d2674ba to af9cf92 Compare July 21, 2023 08:41
@clarani clarani requested a review from nicolaswurtz July 21, 2023 08:56
@clarani clarani dismissed nicolaswurtz’s stale review July 21, 2023 08:58

Nicolas is on holidays, as the change have already been approved by Valentin, I would like to merge ly PR and show the changes to Nicolas later.

@clarani clarani added this pull request to the merge queue Jul 21, 2023
Merged via the queue into dev with commit 0b2b322 Jul 21, 2023
@clarani clarani deleted the lagg/pathfinding-import-migration branch July 21, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants