Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix project page size and allowances in the front (remove capacity_speed_limit param) #4522

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

nicolaswurtz
Copy link
Contributor

No description provided.

@nicolaswurtz nicolaswurtz requested a review from a team as a code owner July 6, 2023 09:14
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #4522 (dcca621) into dev (49ce070) will decrease coverage by 0.01%.
The diff coverage is 4.76%.

@@             Coverage Diff              @@
##                dev    #4522      +/-   ##
============================================
- Coverage     19.79%   19.79%   -0.01%     
  Complexity     2302     2302              
============================================
  Files           860      860              
  Lines         87860    87862       +2     
  Branches       2263     2263              
============================================
- Hits          17394    17393       -1     
- Misses        69214    69217       +3     
  Partials       1252     1252              
Flag Coverage Δ
editoast 61.05% <ø> (-0.03%) ⬇️
front 9.34% <4.76%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/applications/operationalStudies/Home.tsx 0.00% <0.00%> (ø)
...omponents/ManageTrainSchedule/Allowances/consts.ts 0.00% <ø> (ø)
.../applications/operationalStudies/views/Project.tsx 0.00% <0.00%> (ø)
...applications/operationalStudies/views/Scenario.tsx 0.00% <0.00%> (ø)
...ons/operationalStudies/views/SimulationResults.tsx 0.00% <0.00%> (ø)
...rc/applications/operationalStudies/views/Study.tsx 0.00% <0.00%> (ø)
front/src/common/api/osrdEditoastApi.ts 91.73% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! :) tested in local

@clarani clarani added this pull request to the merge queue Jul 6, 2023
@clarani clarani changed the title Nwz/fixes on pagesize and allowances front: fix project page size and allowances in the front (remove capacity_speed_limit param) Jul 6, 2023
@multun multun removed this pull request from the merge queue due to a manual request Jul 6, 2023
@multun multun merged commit 2d007c1 into dev Jul 6, 2023
@multun multun deleted the nwz/fixes-on-pagesize-and-allowances branch July 6, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants