Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast_derive: add Search derive macro #4590

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented Jul 17, 2023

Part of #4580

Replaces the search.yml by derive annotations in order to declare which objects can be searched using utoipa annotations (that will come later).

@leovalais leovalais added the area:editoast Work on Editoast Service label Jul 17, 2023
@leovalais leovalais requested a review from a team as a code owner July 17, 2023 12:21
@leovalais leovalais changed the title Lva/search derive macro editoast_derive: add Search derive macro Jul 17, 2023
@leovalais leovalais marked this pull request as draft July 17, 2023 12:42
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #4590 (75a97f8) into dev (6d3fb02) will increase coverage by 0.14%.
Report is 1 commits behind head on dev.
The diff coverage is 0.00%.

❗ Current head 75a97f8 differs from pull request most recent head c5d9b0a. Consider uploading reports for the commit c5d9b0a to get more accurate results

@@             Coverage Diff              @@
##                dev    #4590      +/-   ##
============================================
+ Coverage     19.88%   20.03%   +0.14%     
  Complexity     2238     2238              
============================================
  Files           878      874       -4     
  Lines         90132    89318     -814     
  Branches       2299     2298       -1     
============================================
- Hits          17926    17895      -31     
+ Misses        70926    70144     -782     
+ Partials       1280     1279       -1     
Flag Coverage Δ
editoast 64.75% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
editoast/src/main.rs 34.14% <ø> (ø)
editoast/src/views/search/mod.rs 2.56% <0.00%> (+0.06%) ⬆️

... and 55 files with indirect coverage changes

@leovalais leovalais force-pushed the lva/search-derive-macro branch 2 times, most recently from df891de to a1e86b1 Compare July 18, 2023 08:36
@multun multun force-pushed the lva/search-derive-macro branch from a1e86b1 to ded8ae5 Compare July 18, 2023 08:59
@leovalais leovalais force-pushed the lva/search-derive-macro branch from 34a634a to 8ec2d7b Compare July 20, 2023 08:57
@leovalais leovalais force-pushed the lva/search-derive-macro branch from 8ec2d7b to e625f4c Compare August 9, 2023 08:52
@leovalais leovalais marked this pull request as ready for review August 10, 2023 09:45
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy!
LGTM.

@leovalais leovalais force-pushed the lva/search-derive-macro branch from 75a97f8 to b670246 Compare August 10, 2023 10:13
@leovalais leovalais force-pushed the lva/search-derive-macro branch from b670246 to 0b407d2 Compare August 10, 2023 13:36
@leovalais leovalais requested a review from multun as a code owner August 10, 2023 13:36
@leovalais leovalais force-pushed the lva/search-derive-macro branch from 0b407d2 to c5d9b0a Compare August 10, 2023 13:43
@leovalais leovalais enabled auto-merge August 10, 2023 14:55
@leovalais leovalais disabled auto-merge August 11, 2023 08:46
@leovalais leovalais added this pull request to the merge queue Aug 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 11, 2023
@leovalais leovalais added this pull request to the merge queue Aug 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 11, 2023
@leovalais leovalais self-assigned this Aug 14, 2023
@leovalais leovalais added this pull request to the merge queue Aug 14, 2023
Merged via the queue into dev with commit 834d287 Aug 14, 2023
@leovalais leovalais deleted the lva/search-derive-macro branch August 14, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants