Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: refacto infras list module #4680

Merged
merged 8 commits into from
Aug 1, 2023
Merged

front: refacto infras list module #4680

merged 8 commits into from
Aug 1, 2023

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Jul 27, 2023 •
edited
Loading

close #4679
close #4683

@SharglutDev SharglutDev requested a review from a team as a code owner July 27, 2023 15:03
@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #4680 (6e6bbb5) into dev (aa21208) will decrease coverage by 0.01%.
The diff coverage is 4.96%.

@@             Coverage Diff              @@
##                dev    #4680      +/-   ##
============================================
- Coverage     19.99%   19.99%   -0.01%     
  Complexity     2325     2325              
============================================
  Files           875      875              
  Lines         88726    88761      +35     
  Branches       2293     2293              
============================================
+ Hits          17745    17750       +5     
- Misses        69709    69739      +30     
  Partials       1272     1272
Flag Coverage Δ
editoast 61.51% <ø> (ø)
front 9.47% <4.96%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...n/InfraSelector/InfraSelectorEditionActionsBar.tsx 0.00% <0.00%> (ø)
...aSelector/InfraSelectorEditionActionsBarDelete.tsx 0.00% <0.00%> (ø)
.../common/InfraSelector/InfraSelectorEditionItem.tsx 0.00% <0.00%> (ø)
...nt/src/common/InfraSelector/InfraSelectorModal.tsx 0.00% <0.00%> (ø)
...on/InfraSelector/InfraSelectorModalBodyEdition.tsx 0.00% <ø> (ø)
...n/InfraSelector/InfraSelectorModalBodyStandard.tsx 0.00% <0.00%> (ø)
front/src/common/InfraSelector/consts.ts 0.00% <0.00%> (ø)
front/src/common/api/osrdEditoastApi.ts 91.38% <72.72%> (-0.12%) ⬇️

@SharglutDev SharglutDev changed the title front: refacto clone infra workflow front: refacto infras list module Jul 28, 2023
@SharglutDev SharglutDev force-pushed the pfn/front/refacto-infras-list-module branch 2 times, most recently from 830d401 to da361e4 Compare July 28, 2023 10:45
@SharglutDev SharglutDev requested a review from a team as a code owner July 28, 2023 10:45
Uriel-Sautron
Uriel-Sautron reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work, tested on local

@SharglutDev SharglutDev force-pushed the pfn/front/refacto-infras-list-module branch from da361e4 to 6e6bbb5 Compare August 1, 2023 10:37
@SharglutDev SharglutDev added this pull request to the merge queue Aug 1, 2023
Merged via the queue into dev with commit 480c9ac Aug 1, 2023
@SharglutDev SharglutDev deleted the pfn/front/refacto-infras-list-module branch August 1, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uriel-Sautron Uriel-Sautron Uriel-Sautron left review comments

@Math-R Math-R Math-R approved these changes

@Tguisnet Tguisnet Tguisnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List of infra limited to 25 entries front: refacto and migrate infras list editor module
4 participants
@SharglutDev @Math-R @Tguisnet @Uriel-Sautron