core: spacing requirements: gracefuly handle faulty signaling #4741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A faulty signal may always display a non-constraining state, regardless of the state of zones ahead. In this case, use the time the zone is first occupied as the requirement start time. This change also introduces various checks, including a state machine which ensure signaling behaves as expected. Fixes #4735
multun
force-pushed
the
spacing-faulty-signaling
branch
from
c0297b6 to
cc3884f
Compare
Khoyo
approved these changes
Aug 3, 2023
Codecov Report
@@ Coverage Diff @@
## dev #4741 +/- ##
=========================================
Coverage 20.29% 20.30%
- Complexity 2327 2330 +3
=========================================
Files 877 877
Lines 89077 89115 +38
Branches 2303 2320 +17
=========================================
+ Hits 18076 18092 +16
- Misses 69726 69738 +12
- Partials 1275 1285 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A faulty signal may always display a non-constraining state, regardless of the state of zones ahead. In this case, use the time the zone is first occupied as the requirement start time.
This change also introduces various checks, including a state machine which ensure signaling behaves as expected.
Fixes #4735