Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add multi select on scenario timetable trainschedule, allow su… #4770

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Aug 8, 2023

…ppression of multiple trainSchedule, create new generic delete modal

close #4582 #4713

@Math-R Math-R requested a review from a team as a code owner August 8, 2023 14:22
@Math-R Math-R requested review from SharglutDev and clarani August 8, 2023 14:22
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #4770 (ea54c71) into dev (9883cf8) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #4770      +/-   ##
============================================
- Coverage     20.01%   19.97%   -0.04%     
  Complexity     2238     2238              
============================================
  Files           877      878       +1     
  Lines         89720    89884     +164     
  Branches       2300     2301       +1     
============================================
  Hits          17953    17953              
- Misses        70486    70649     +163     
- Partials       1281     1282       +1     
Flag Coverage Δ
front 9.51% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...erationalStudies/components/Scenario/Timetable.tsx 0.00% <0.00%> (ø)
...Studies/components/Scenario/TimetableTrainCard.tsx 0.00% <0.00%> (ø)
.../SimulationResults/SpaceTimeChart/withOSRDData.jsx 0.00% <0.00%> (ø)
...src/common/BootstrapSNCF/ModalSNCF/DeleteModal.tsx 0.00% <0.00%> (ø)

@Math-R Math-R force-pushed the mrd/select-multiple-trains branch from 8641604 to 6e740bb Compare August 8, 2023 14:51
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! :) I left some commnts

@Math-R Math-R force-pushed the mrd/select-multiple-trains branch from 6e740bb to 2e184f5 Compare August 9, 2023 14:01
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in local ✔️

@Math-R Math-R force-pushed the mrd/select-multiple-trains branch from 2e184f5 to c6eac35 Compare August 9, 2023 14:14
@Math-R Math-R enabled auto-merge August 9, 2023 14:14
@Math-R Math-R force-pushed the mrd/select-multiple-trains branch from c6eac35 to 0d71781 Compare August 9, 2023 15:14
…ppression of multiple trainSchedule, create new generic delete modal
@Math-R Math-R force-pushed the mrd/select-multiple-trains branch from 0d71781 to ea54c71 Compare August 9, 2023 18:28
@Math-R Math-R added this pull request to the merge queue Aug 9, 2023
Merged via the queue into dev with commit 467ea7b Aug 9, 2023
@Math-R Math-R deleted the mrd/select-multiple-trains branch August 9, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select multiple trains
2 participants