Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nwz/add 3D terrain to maps #4832

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Nwz/add 3D terrain to maps #4832

merged 2 commits into from
Aug 22, 2023

Conversation

nicolaswurtz
Copy link
Contributor

@nicolaswurtz nicolaswurtz commented Aug 16, 2023

image
image

close #4792

@nicolaswurtz nicolaswurtz requested a review from a team as a code owner August 16, 2023 22:44
@nicolaswurtz nicolaswurtz changed the title Nwz/add 3 d terrain to map Nwz/add 3D terrain to maps Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4832 (2fb9ab4) into dev (ea37389) will increase coverage by 0.04%.
The diff coverage is 10.22%.

❗ Current head 2fb9ab4 differs from pull request most recent head ff9015d. Consider uploading reports for the commit ff9015d to get more accurate results

@@             Coverage Diff              @@
##                dev    #4832      +/-   ##
============================================
+ Coverage     21.80%   21.85%   +0.04%     
  Complexity     2248     2248              
============================================
  Files           861      857       -4     
  Lines         90299    90053     -246     
  Branches       2284     2286       +2     
============================================
- Hits          19692    19682      -10     
+ Misses        69346    69108     -238     
- Partials       1261     1263       +2     
Flag Coverage Δ
front 9.70% <10.22%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
front/src/applications/editor/Map.tsx 0.00% <0.00%> (ø)
...onalStudies/components/ManageTrainSchedule/Map.tsx 0.00% <0.00%> (ø)
...ponents/SimulationResults/SimulationResultsMap.tsx 0.00% <0.00%> (ø)
front/src/applications/referenceMap/Map.tsx 0.00% <0.00%> (ø)
front/src/common/Map/Layers/Hillshade.tsx 0.00% <0.00%> (ø)
front/src/common/Map/Layers/Terrain.tsx 0.00% <0.00%> (ø)
...mon/Map/Settings/MapSettingsBackgroundSwitches.jsx 0.00% <0.00%> (ø)
front/src/reducers/map/index.ts 48.83% <29.41%> (-1.01%) ⬇️
front/src/reducers/map/selectors.ts 100.00% <100.00%> (ø)

... and 82 files with indirect coverage changes

@nicolaswurtz nicolaswurtz force-pushed the nwz/add-3D-terrain-to-map branch 4 times, most recently from 20f35c4 to 3cd5d87 Compare August 22, 2023 09:40
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nicolaswurtz nicolaswurtz force-pushed the nwz/add-3D-terrain-to-map branch from 3cd5d87 to ff9015d Compare August 22, 2023 13:55
@nicolaswurtz nicolaswurtz merged commit 9c781be into dev Aug 22, 2023
@nicolaswurtz nicolaswurtz deleted the nwz/add-3D-terrain-to-map branch August 22, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map: some labels are in english instead of french
3 participants