Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: remove custom GET #4838

Merged
merged 1 commit into from
Aug 21, 2023
Merged

front: remove custom GET #4838

merged 1 commit into from
Aug 21, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Aug 17, 2023

close #4836

@clarani clarani requested a review from a team as a code owner August 17, 2023 08:50
@clarani clarani added the area:front Work on Standard OSRD Interface modules label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #4838 (05ac83d) into dev (2626967) will increase coverage by 0.50%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #4838      +/-   ##
============================================
+ Coverage     21.35%   21.86%   +0.50%     
  Complexity     2245     2245              
============================================
  Files           876      856      -20     
  Lines         92104    89967    -2137     
  Branches       2304     2284      -20     
============================================
  Hits          19667    19667              
+ Misses        71154    69037    -2117     
+ Partials       1283     1263      -20
Flag Coverage Δ
front 9.70% <0.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../ImportTrainSchedule/ImportTrainScheduleConfig.tsx 0.00% <0.00%> (ø)
...on/InfraSelector/InfraSelectorModalBodyEdition.tsx 0.00% <0.00%> (ø)
front/src/common/uploadFileModal.jsx 0.00% <0.00%> (ø)
front/src/main/app.jsx 0.00% <ø> (ø)
front/src/main/home.jsx 0.00% <ø> (ø)

@nicolaswurtz nicolaswurtz self-assigned this Aug 18, 2023
nicolaswurtz
nicolaswurtz approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@nicolaswurtz nicolaswurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG :)

@clarani clarani added this pull request to the merge queue Aug 21, 2023
Merged via the queue into dev with commit 7b172a0 Aug 21, 2023
@clarani clarani deleted the cni-front-4836-remove-custom-GET branch August 21, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

Assignees

@nicolaswurtz nicolaswurtz

Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: remove customGET
2 participants
@clarani @nicolaswurtz