Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: refactorization: add modules => scenario, study, project, roll… #4875

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Aug 23, 2023

…ingStock, conflict

@Math-R Math-R requested a review from a team as a code owner August 23, 2023 15:30
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4875 (467096d) into dev (a7bf4b6) will decrease coverage by 0.39%.
The diff coverage is 0.00%.

❗ Current head 467096d differs from pull request most recent head 435f358. Consider uploading reports for the commit 435f358 to get more accurate results

@@             Coverage Diff              @@
##                dev    #4875      +/-   ##
============================================
- Coverage     22.36%   21.98%   -0.39%     
  Complexity     2276     2276              
============================================
  Files           862      863       +1     
  Lines         90257    90582     +325     
  Branches       2323     2317       -6     
============================================
- Hits          20188    19913     -275     
- Misses        68793    69399     +606     
+ Partials       1276     1270       -6     
Flag Coverage Δ
front 9.67% <0.00%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
front/src/applications/operationalStudies/Home.tsx 0.00% <0.00%> (ø)
.../ImportTrainSchedule/ImportTrainScheduleConfig.tsx 0.00% <0.00%> (ø)
...rtTrainSchedule/ImportTrainScheduleTrainDetail.tsx 0.00% <0.00%> (ø)
...erationalStudies/components/Scenario/Timetable.tsx 0.00% <0.00%> (ø)
...Studies/components/Scenario/TimetableTrainCard.tsx 0.00% <0.00%> (ø)
...s/operationalStudies/views/ManageTrainSchedule.tsx 0.00% <0.00%> (ø)
.../applications/operationalStudies/views/Project.tsx 0.00% <0.00%> (ø)
...applications/operationalStudies/views/Scenario.tsx 0.00% <0.00%> (ø)
...ons/operationalStudies/views/SimulationResults.tsx 0.00% <0.00%> (ø)
...rc/applications/operationalStudies/views/Study.tsx 0.00% <0.00%> (ø)
... and 36 more

... and 33 files with indirect coverage changes

@Math-R Math-R force-pushed the mrd/implement-new-nomenclature branch from 467096d to 435f358 Compare August 25, 2023 09:17
@Math-R Math-R force-pushed the mrd/implement-new-nomenclature branch from 435f358 to 433a413 Compare August 25, 2023 09:34
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested ✔️

@Math-R Math-R enabled auto-merge August 25, 2023 13:44
@nicolaswurtz nicolaswurtz disabled auto-merge August 25, 2023 13:45
@nicolaswurtz nicolaswurtz merged commit 4ca4c63 into dev Aug 25, 2023
@nicolaswurtz nicolaswurtz deleted the mrd/implement-new-nomenclature branch August 25, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants