Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: operationalStudies: migrate SpaceTimeChart #4993

Merged
merged 1 commit into from
Sep 19, 2023
Merged

front: operationalStudies: migrate SpaceTimeChart #4993

merged 1 commit into from
Sep 19, 2023

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented Sep 7, 2023 •
edited by clarani
Loading

closes #4957

@kmer2016 kmer2016 linked an issue Sep 7, 2023 that may be closed by this pull request
front: migrate SpaceTimeChart files to typescript #4957
Closed
4 tasks
@kmer2016 kmer2016 force-pushed the cnh/front-migrate-spacetimechart-files-to-typescript branch from 0187000 to 13840c3 Compare September 13, 2023 13:13
@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #4993 (fccbbd5) into dev (16870c4) will decrease coverage by 0.02%.
The diff coverage is 3.75%.

@@             Coverage Diff              @@
##                dev    #4993      +/-   ##
============================================
- Coverage     21.57%   21.56%   -0.02%     
  Complexity     2455     2455              
============================================
  Files           862      863       +1     
  Lines         91069    91131      +62     
  Branches       2502     2503       +1     
============================================
+ Hits          19651    19652       +1     
- Misses        70048    70108      +60     
- Partials       1370     1371       +1
Flag Coverage Δ
front 8.42% <3.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ents/SimulationResults/ChartHelpers/defineChart.ts 0.00% <0.00%> (ø)
...ponents/SimulationResults/ChartHelpers/drawRect.ts 0.00% <0.00%> (ø)
...ponents/SimulationResults/ChartHelpers/drawText.ts 0.00% <0.00%> (ø)
...riverTrainSchedule/DriverTrainScheduleStopList.tsx 0.00% <0.00%> (ø)
...imulationResults/SpaceTimeChart/SpaceTimeChart.tsx 0.00% <0.00%> (ø)
...ts/SimulationResults/SpaceTimeChart/createChart.ts 0.00% <0.00%> (ø)
...ents/SimulationResults/SpaceTimeChart/d3Helpers.ts 0.00% <0.00%> (ø)
...ents/SimulationResults/SpaceTimeChart/drawTrain.ts 0.00% <0.00%> (ø)
...mponents/SimulationResults/SpaceTimeChart/types.ts 0.00% <0.00%> (ø)
.../SimulationResults/SpaceTimeChart/withOSRDData.tsx 0.00% <0.00%> (ø)
... and 4 more

@kmer2016 kmer2016 force-pushed the cnh/front-migrate-spacetimechart-files-to-typescript branch from 13840c3 to d74f2e3 Compare September 13, 2023 14:16
clarani
clarani requested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments :)

@kmer2016 kmer2016 force-pushed the cnh/front-migrate-spacetimechart-files-to-typescript branch 2 times, most recently from 0406586 to 2dea38d Compare September 18, 2023 10:25
clarani
clarani approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this PR ! Tested ✔️

anisometropie
anisometropie requested changes Sep 18, 2023
View reviewed changes
@kmer2016 kmer2016 marked this pull request as ready for review September 18, 2023 18:03
@kmer2016 kmer2016 requested a review from a team as a code owner September 18, 2023 18:03
@kmer2016 kmer2016 force-pushed the cnh/front-migrate-spacetimechart-files-to-typescript branch from 2dea38d to 971de73 Compare September 19, 2023 12:46
@kmer2016 kmer2016 force-pushed the cnh/front-migrate-spacetimechart-files-to-typescript branch from 971de73 to d8a1026 Compare September 19, 2023 14:04
@kmer2016 kmer2016 force-pushed the cnh/front-migrate-spacetimechart-files-to-typescript branch from d8a1026 to fccbbd5 Compare September 19, 2023 14:44
@kmer2016 kmer2016 added this pull request to the merge queue Sep 19, 2023
Merged via the queue into dev with commit 6663bd3 Sep 19, 2023
@kmer2016 kmer2016 deleted the cnh/front-migrate-spacetimechart-files-to-typescript branch September 19, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anisometropie anisometropie anisometropie approved these changes

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: migrate SpaceTimeChart files to typescript
3 participants
@kmer2016 @anisometropie @clarani