-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model v2 macro to editoast #5033
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5033 +/- ##
============================================
+ Coverage 19.73% 19.83% +0.09%
Complexity 2117 2117
============================================
Files 910 912 +2
Lines 108673 108904 +231
Branches 2663 2663
============================================
+ Hits 21452 21606 +154
- Misses 85650 85727 +77
Partials 1571 1571
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c59c9f6
to
c42b92f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
We could improve the error handling of the macro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
783146d
to
ab0928f
Compare
Go 🚀 |
74b327f
to
5a65ca3
Compare
Part of #4184
ModelV2
derive macroPatch<'a, Model>
objectsjson
andgeo
Document
modelTestFixture
objectsThings left to do:
InfraModel
: editoast: generate specific interfaces for infra objects models #4807#[model(json)]
attribute macrogeo
as well#[model(to_string)]
attribute macro#[model(diesel(...))]
directive to forward diesel configuration at both type and field level (useful forbelongs_to
among other things)study: Study
field in theProject
model instead of aproject_id
inStudy
)Schema (may be probably 100% accurate, more or less):
(The red tag means that it's generated by the macro, the export deleted the text 😢)