Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: implement new nomenclature part 2 #5062

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Sep 15, 2023

No description provided.

@Math-R Math-R force-pushed the mrd/implement-new-nomenclature branch 2 times, most recently from e351834 to c346ade Compare October 2, 2023 10:12
@Math-R Math-R marked this pull request as ready for review October 2, 2023 10:12
@Math-R Math-R requested a review from a team as a code owner October 2, 2023 10:12
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #5062 (737e970) into dev (6fc6ddb) will decrease coverage by 0.01%.
Report is 1 commits behind head on dev.
The diff coverage is 5.03%.

@@             Coverage Diff              @@
##                dev    #5062      +/-   ##
============================================
- Coverage     18.62%   18.61%   -0.01%     
  Complexity     2469     2469              
============================================
  Files           859      861       +2     
  Lines        106439   106458      +19     
  Branches       2500     2502       +2     
============================================
  Hits          19820    19820              
- Misses        85252    85269      +17     
- Partials       1367     1369       +2     
Flag Coverage Δ
front 7.01% <5.03%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
front/src/common/Pathfinding/Pathfinding.tsx 24.69% <100.00%> (ø)
...onents/RollingStockEditor/AddRollingstockParam.tsx 0.00% <ø> (ø)
...ents/RollingStockEditor/RollingStockEditorCard.tsx 0.00% <ø> (ø)
...ts/RollingStockEditor/RollingStockEditorCurves.tsx 0.00% <ø> (ø)
...llingStockEditor/RollingStockEditorFormHelpers.tsx 0.00% <ø> (ø)
...RollingStockEditor/RollingStockEditorFormModal.tsx 0.00% <ø> (ø)
...tionResult/components/ChartHelpers/ChartHelpers.ts 44.04% <100.00%> (ø)
...lationResult/components/ChartHelpers/drawCurve.jsx 0.00% <ø> (ø)
.../components/ChartHelpers/drawElectricalProfile.jsx 0.00% <ø> (ø)
...onResult/components/ChartHelpers/drawGuideLines.ts 0.00% <ø> (ø)
... and 116 more

... and 2 files with indirect coverage changes

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local, good to me

@Math-R Math-R force-pushed the mrd/implement-new-nomenclature branch 2 times, most recently from 6e1fb83 to 2f47dbf Compare October 3, 2023 09:42
@Math-R Math-R force-pushed the mrd/implement-new-nomenclature branch from 2f47dbf to 737e970 Compare October 3, 2023 09:50
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks !! 🎉 tested on my local

@clarani clarani added this pull request to the merge queue Oct 3, 2023
Merged via the queue into dev with commit be1aea7 Oct 3, 2023
@clarani clarani deleted the mrd/implement-new-nomenclature branch October 3, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants