Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: use std::io::IsTerminal instead of atty #5095

Merged
merged 1 commit into from
Sep 19, 2023
Merged

editoast: use std::io::IsTerminal instead of atty #5095

merged 1 commit into from
Sep 19, 2023

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Sep 19, 2023

atty is unmaintained since 2021, and the standard library IsTerminal is now stable.

Fixes #190

atty is unmaintained since 2021, and the standard library IsTerminal is
now stable.
@Khoyo Khoyo added the area:editoast Work on Editoast Service label Sep 19, 2023
@Khoyo Khoyo requested a review from a team as a code owner September 19, 2023 15:02
@Khoyo Khoyo self-assigned this Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #5095 (903e853) into dev (16870c4) will increase coverage by 0.00%.
Report is 2 commits behind head on dev.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev    #5095   +/-   ##
=========================================
  Coverage     21.57%   21.57%           
  Complexity     2455     2455           
=========================================
  Files           862      862           
  Lines         91069    91069           
  Branches       2502     2502           
=========================================
+ Hits          19651    19652    +1     
+ Misses        70048    70047    -1     
  Partials       1370     1370           
Flag Coverage Δ
editoast 69.07% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
editoast/src/main.rs 7.98% <0.00%> (ø)

... and 2 files with indirect coverage changes

@Khoyo Khoyo added this pull request to the merge queue Sep 19, 2023
Merged via the queue into dev with commit 2a5dfd3 Sep 19, 2023
@Khoyo Khoyo deleted the yk/drop-atty branch September 19, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants