-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: merging conflicts with overlapping times #5110
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5110 +/- ##
============================================
+ Coverage 18.62% 18.64% +0.02%
Complexity 2469 2469
============================================
Files 859 859
Lines 106439 106479 +40
Branches 2500 2513 +13
============================================
+ Hits 19820 19856 +36
- Misses 85252 85254 +2
- Partials 1367 1369 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for the PR title (and the commit), I'd suggest core: merge conflicts with overlapping time
See our guidelines: https://osrd.fr/en/docs/guides/contribute/code/#git-commit-style
Keep the reference to the issue in the commit body or the body of the PR.
Additionally, if you add something like Closes #4921.
in the body of the PR, github will auto close the issue when the PR is merged ;)
6bb0334
to
ec0eabd
Compare
ec0eabd
to
c199e5d
Compare
c199e5d
to
e38c189
Compare
Closes #4921