Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: merging conflicts with overlapping times #5110

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

anglnn
Copy link
Contributor

@anglnn anglnn commented Sep 20, 2023

Closes #4921

@anglnn anglnn requested a review from a team as a code owner September 20, 2023 14:52
@anglnn anglnn changed the title merging conflicts with overlapping times #4921 merging conflicts with overlapping times Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #5110 (e38c189) into dev (6fc6ddb) will increase coverage by 0.02%.
Report is 9 commits behind head on dev.
The diff coverage is 90.47%.

@@             Coverage Diff              @@
##                dev    #5110      +/-   ##
============================================
+ Coverage     18.62%   18.64%   +0.02%     
  Complexity     2469     2469              
============================================
  Files           859      859              
  Lines        106439   106479      +40     
  Branches       2500     2513      +13     
============================================
+ Hits          19820    19856      +36     
- Misses        85252    85254       +2     
- Partials       1367     1369       +2     
Flag Coverage Δ
core 79.23% <90.47%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../src/main/java/fr/sncf/osrd/conflicts/Conflicts.kt 76.68% <90.47%> (+4.32%) ⬆️

Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the PR title (and the commit), I'd suggest core: merge conflicts with overlapping time

See our guidelines: https://osrd.fr/en/docs/guides/contribute/code/#git-commit-style

Keep the reference to the issue in the commit body or the body of the PR.

Additionally, if you add something like Closes #4921. in the body of the PR, github will auto close the issue when the PR is merged ;)

@anglnn anglnn requested review from a team as code owners September 28, 2023 15:01
@anglnn anglnn changed the title merging conflicts with overlapping times core: merging conflicts with overlapping times Sep 29, 2023
@multun multun force-pushed the akz/merge-conflicts branch 2 times, most recently from 6bb0334 to ec0eabd Compare October 3, 2023 12:50
@anglnn anglnn force-pushed the akz/merge-conflicts branch from ec0eabd to c199e5d Compare October 3, 2023 13:08
@anglnn anglnn force-pushed the akz/merge-conflicts branch from c199e5d to e38c189 Compare October 3, 2023 13:52
@multun multun added this pull request to the merge queue Oct 3, 2023
Merged via the queue into dev with commit d4c9d0f Oct 3, 2023
@multun multun deleted the akz/merge-conflicts branch October 3, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many conflicts
3 participants