Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: add endpoint that retrieve the power restrictions list #5185

Merged
merged 1 commit into from
Oct 4, 2023
Merged

editoast: add endpoint that retrieve the power restrictions list #5185

merged 1 commit into from
Oct 4, 2023

Conversation

younesschrifi
Copy link
Contributor

No description provided.

@younesschrifi younesschrifi force-pushed the yci/power-restriction-endpoint branch 2 times, most recently from 330b503 to dcfd997 Compare October 3, 2023 10:11
@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #5185 (7f4112f) into dev (722ec6a) will increase coverage by 0.03%.
Report is 17 commits behind head on dev.
The diff coverage is 72.22%.

@@             Coverage Diff              @@
##                dev    #5185      +/-   ##
============================================
+ Coverage     18.83%   18.86%   +0.03%     
  Complexity     2469     2469              
============================================
  Files           860      860              
  Lines        104629   104579      -50     
  Branches       2515     2512       -3     
============================================
+ Hits          19704    19734      +30     
+ Misses        83554    83477      -77     
+ Partials       1371     1368       -3
Flag Coverage Δ
editoast 69.23% <100.00%> (+0.01%) ⬆️
front 7.02% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
editoast/src/views/rolling_stocks/mod.rs 63.52% <100.00%> (+1.56%) ⬆️
front/src/common/api/osrdEditoastApi.ts 92.10% <50.00%> (+0.08%) ⬆️

... and 23 files with indirect coverage changes

@younesschrifi younesschrifi force-pushed the yci/power-restriction-endpoint branch 5 times, most recently from 86c2b14 to 323a14d Compare October 3, 2023 16:26
@younesschrifi younesschrifi marked this pull request as ready for review October 3, 2023 16:26
@younesschrifi younesschrifi requested a review from a team as a code owner October 3, 2023 16:26
@younesschrifi younesschrifi force-pushed the yci/power-restriction-endpoint branch 4 times, most recently from 1a6bae5 to 601d28c Compare October 3, 2023 21:38
leovalais
leovalais requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally.

Castavo
Castavo approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame that diesel forces us to use a QueryableByName in this case, but I couldn't find a workaround either 😁

Tested locally, the endpoint seems to work 👍

@younesschrifi younesschrifi force-pushed the yci/power-restriction-endpoint branch 2 times, most recently from d55af8a to 0a14c43 Compare October 4, 2023 13:44
leovalais
leovalais approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just add the tag in the annotation :)

@younesschrifi younesschrifi force-pushed the yci/power-restriction-endpoint branch from 0a14c43 to 97fadd0 Compare October 4, 2023 14:07
@younesschrifi younesschrifi force-pushed the yci/power-restriction-endpoint branch from 97fadd0 to 7f4112f Compare October 4, 2023 14:25
@younesschrifi younesschrifi added this pull request to the merge queue Oct 4, 2023
Merged via the queue into dev with commit 939092a Oct 4, 2023
@younesschrifi younesschrifi deleted the yci/power-restriction-endpoint branch October 4, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovalais leovalais leovalais approved these changes

@Castavo Castavo Castavo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@younesschrifi @leovalais @Castavo