Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refacto store: mainSlice #5207

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Refacto store: mainSlice #5207

merged 3 commits into from
Oct 12, 2023

Conversation

Uriel-Sautron
Copy link
Contributor

close #5195

  • Creating mainSlice
  • Create mainSelector and use it in the application
  • Creating tests for mainReducer

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner October 4, 2023 14:34
@Uriel-Sautron Uriel-Sautron force-pushed the usn/refacto-store-user-main branch from d7d3061 to 763f231 Compare October 4, 2023 14:48
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Merging #5207 (ef3507f) into dev (7587b40) will increase coverage by 0.05%.
Report is 2 commits behind head on dev.
The diff coverage is 66.29%.

@@             Coverage Diff              @@
##                dev    #5207      +/-   ##
============================================
+ Coverage     18.78%   18.84%   +0.05%     
  Complexity     2327     2327              
============================================
  Files           853      853              
  Lines        103404   103190     -214     
  Branches       2401     2402       +1     
============================================
+ Hits          19429    19444      +15     
+ Misses        82639    82409     -230     
- Partials       1336     1337       +1
Flag Coverage Δ
front 7.09% <66.29%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
front/src/reducers/index.ts 100.00% <100.00%> (ø)
front/src/reducers/main/mainSelector.ts 100.00% <100.00%> (ø)
front/src/applications/referenceMap/Map.tsx 0.00% <0.00%> (ø)
front/src/applications/stdcm/formatStcmConf.ts 0.00% <0.00%> (ø)
...src/applications/stdcm/views/StdcmRequestModal.tsx 0.00% <0.00%> (ø)
front/src/common/BootstrapSNCF/ToastSNCF.tsx 0.00% <0.00%> (ø)
front/src/common/ButtonFullscreen.tsx 0.00% <0.00%> (ø)
front/src/common/Loader.tsx 91.11% <50.00%> (ø)
front/src/reducers/user/index.ts 55.03% <92.30%> (+3.34%) ⬆️
front/src/types/index.ts 0.00% <0.00%> (ø)
... and 11 more

... and 3 files with indirect coverage changes

@Uriel-Sautron Uriel-Sautron force-pushed the usn/refacto-store-user-main branch from 763f231 to 609dcf7 Compare October 5, 2023 06:36
Yohh
Yohh approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

clarani
clarani reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@kmer2016 kmer2016 force-pushed the usn/refacto-store-user-main branch 3 times, most recently from 921251e to 38c17e1 Compare October 12, 2023 09:05
@kmer2016 kmer2016 force-pushed the usn/refacto-store-user-main branch from 38c17e1 to ef3507f Compare October 12, 2023 10:12
clarani
clarani approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested in local ✔️

@kmer2016 kmer2016 added this pull request to the merge queue Oct 12, 2023
Merged via the queue into dev with commit 495833d Oct 12, 2023
@kmer2016 kmer2016 deleted the usn/refacto-store-user-main branch October 12, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmer2016 kmer2016 kmer2016 left review comments

@alexandredamiron alexandredamiron alexandredamiron approved these changes

@Yohh Yohh Yohh approved these changes

@clarani clarani clarani approved these changes

Assignees

@kmer2016 kmer2016

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refacto store: Slice main
5 participants
@Uriel-Sautron @alexandredamiron @kmer2016 @Yohh @clarani