Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: migrate chartHelpers files to ts #5227

Merged
merged 1 commit into from
Oct 9, 2023
Merged

front: migrate chartHelpers files to ts #5227

merged 1 commit into from
Oct 9, 2023

Conversation

SarahBellaha
Copy link
Contributor

Closes #4956

@SarahBellaha SarahBellaha added the area:front Work on Standard OSRD Interface modules label Oct 5, 2023
@SarahBellaha SarahBellaha requested a review from a team as a code owner October 5, 2023 14:49
@SarahBellaha SarahBellaha force-pushed the sba/front/migrate-charthelpers-files-to-ts branch from 8255951 to 8a4e987 Compare October 5, 2023 14:55
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #5227 (1b42123) into dev (b95abdf) will increase coverage by 0.02%.
The diff coverage is 2.04%.

@@             Coverage Diff              @@
##                dev    #5227      +/-   ##
============================================
+ Coverage     18.62%   18.64%   +0.02%     
  Complexity     2318     2318              
============================================
  Files           855      856       +1     
  Lines        104154   104047     -107     
  Branches       2408     2409       +1     
============================================
+ Hits          19398    19404       +6     
+ Misses        83416    83302     -114     
- Partials       1340     1341       +1
Flag Coverage Δ
front 7.04% <2.04%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ront/src/applications/operationalStudies/consts.ts 78.16% <100.00%> (+0.31%) ⬆️
...imulationResult/components/ChartHelpers/svgDefs.ts 0.00% <0.00%> (ø)
front/src/utils/types.ts 0.00% <0.00%> (ø)
...tionResult/components/SpeedSpaceChart/d3Helpers.ts 0.00% <0.00%> (ø)
.../simulationResult/components/SpaceCurvesSlopes.tsx 0.00% <0.00%> (ø)
...ationResult/components/ChartHelpers/drawHelpers.ts 0.00% <0.00%> (ø)
...lt/components/ChartHelpers/drawPowerRestriction.ts 0.00% <0.00%> (ø)
...ulationResult/components/ChartHelpers/drawCurve.ts 0.00% <0.00%> (ø)
...t/components/ChartHelpers/drawElectricalProfile.ts 0.00% <0.00%> (ø)

@SarahBellaha SarahBellaha force-pushed the sba/front/migrate-charthelpers-files-to-ts branch from 8a4e987 to 97a1ddd Compare October 5, 2023 17:45
SharglutDev
SharglutDev reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local, very nice job ! Just a few suggestions

@SarahBellaha SarahBellaha force-pushed the sba/front/migrate-charthelpers-files-to-ts branch from 97a1ddd to 1b42123 Compare October 6, 2023 17:23
SharglutDev
SharglutDev approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :)

Math-R
Math-R approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SarahBellaha SarahBellaha added this pull request to the merge queue Oct 9, 2023
Merged via the queue into dev with commit d97452f Oct 9, 2023
@SarahBellaha SarahBellaha deleted the sba/front/migrate-charthelpers-files-to-ts branch October 9, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandredamiron alexandredamiron alexandredamiron left review comments

@Math-R Math-R Math-R approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: migrate SimulationResults/ChartHelpers files to typescript
4 participants
@SarahBellaha @alexandredamiron @Math-R @SharglutDev