Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: use tls connection for all cli commands #5248

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Oct 6, 2023

No description provided.

@Castavo Castavo requested a review from a team as a code owner October 6, 2023 16:09
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #5248 (0c17a4b) into dev (1bd551d) will increase coverage by 0.01%.
Report is 7 commits behind head on dev.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                dev    #5248      +/-   ##
============================================
+ Coverage     18.88%   18.90%   +0.01%     
  Complexity     2469     2469              
============================================
  Files           860      860              
  Lines        104612   104566      -46     
  Branches       2512     2512              
============================================
+ Hits          19761    19772      +11     
+ Misses        83483    83426      -57     
  Partials       1368     1368              
Flag Coverage Δ
editoast 70.02% <50.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
editoast/src/main.rs 19.75% <50.00%> (+6.20%) ⬆️

... and 34 files with indirect coverage changes

@Castavo Castavo changed the title editoast: use tsl connection for all cli commands editoast: use tls connection for all cli commands Oct 9, 2023
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not tested.

@Castavo Castavo added this pull request to the merge queue Oct 10, 2023
Merged via the queue into dev with commit f67d2e8 Oct 10, 2023
@Castavo Castavo deleted the bpt/editoast/tsl-connection-everywhere branch October 10, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants