Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: refacto import modal and clean button colors #5255

Merged
merged 1 commit into from
Oct 12, 2023
Merged

front: refacto import modal and clean button colors #5255

merged 1 commit into from
Oct 12, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 9, 2023

closes #4900

@clarani clarani requested a review from a team as a code owner October 9, 2023 10:13
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #5255 (e9be32b) into dev (3cbed1c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #5255      +/-   ##
============================================
- Coverage     18.76%   18.75%   -0.02%     
  Complexity     2318     2318              
============================================
  Files           852      852              
  Lines        103361   103424      +63     
  Branches       2408     2408              
============================================
  Hits          19395    19395              
- Misses        82628    82691      +63     
  Partials       1338     1338
Flag Coverage Δ
front 7.04% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/ImportTrainSchedule/ImportTrainScheduleModal.tsx 0.00% <0.00%> (ø)

Yohh
Yohh approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

SharglutDev
SharglutDev reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, nice refacto :) Tested in local for different cases and everything works.
Just left one (annoying) comment

@clarani clarani force-pushed the cni-4900-import-error-message-in-red branch from 3bd5a07 to e9be32b Compare October 11, 2023 12:46
Math-R
Math-R approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clarani clarani added this pull request to the merge queue Oct 12, 2023
Merged via the queue into dev with commit 8775fea Oct 12, 2023
@clarani clarani deleted the cni-4900-import-error-message-in-red branch October 12, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yohh Yohh Yohh approved these changes

@Math-R Math-R Math-R approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: import: when pathfinding fails, message should be in red
4 participants
@clarani @Yohh @Math-R @SharglutDev