Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate enableinteractivity to typescript #5258

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Migrate enableinteractivity to typescript #5258

merged 3 commits into from
Nov 7, 2023

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Oct 9, 2023 •
edited by clarani
Loading

closes #5156

@anisometropie anisometropie force-pushed the sba/front/ts-migration-enableinteractivity-component branch 2 times, most recently from 2bd4392 to 14d9130 Compare October 17, 2023 14:40
@anisometropie anisometropie force-pushed the sba/front/ts-migration-enableinteractivity-component branch from 1d3a30c to a24e78d Compare October 25, 2023 14:40
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #5258 (e7e92a3) into dev (c2b9acd) will increase coverage by 0.13%.
Report is 6 commits behind head on dev.
The diff coverage is 24.05%.

@@             Coverage Diff              @@
##                dev    #5258      +/-   ##
============================================
+ Coverage     19.48%   19.62%   +0.13%     
  Complexity     2322     2322              
============================================
  Files           878      879       +1     
  Lines        105486   105471      -15     
  Branches       2544     2566      +22     
============================================
+ Hits          20553    20697     +144     
+ Misses        83452    83271     -181     
- Partials       1481     1503      +22
Flag Coverage Δ
front 8.37% <24.05%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ront/src/applications/operationalStudies/consts.ts 78.11% <100.00%> (ø)
...lationResult/components/simulationResultsConsts.ts 100.00% <100.00%> (ø)
front/src/reducers/osrdconf/index.ts 33.14% <100.00%> (ø)
front/src/reducers/osrdsimulation/types.ts 99.61% <100.00%> (+<0.01%) ⬆️
front/src/utils/timeManipulation.ts 56.81% <100.00%> (+9.44%) ⬆️
...tudies/components/Scenario/getSimulationResults.ts 0.00% <0.00%> (ø)
front/src/common/types.ts 0.00% <0.00%> (ø)
...onents/SimulationResultsMap/TrainHoverPosition.tsx 0.00% <0.00%> (ø)
...ionResult/components/SimulationResultsMap/types.ts 0.00% <0.00%> (ø)
...ionResult/components/SpaceTimeChart/createTrain.ts 31.19% <66.66%> (+0.63%) ⬆️
... and 21 more

... and 8 files with indirect coverage changes

@anisometropie anisometropie force-pushed the sba/front/ts-migration-enableinteractivity-component branch 4 times, most recently from 2f7b7e0 to 16168ec Compare October 27, 2023 12:56
@anisometropie anisometropie marked this pull request as ready for review October 27, 2023 12:58
@anisometropie anisometropie requested a review from a team as a code owner October 27, 2023 12:58
@anisometropie anisometropie force-pushed the sba/front/ts-migration-enableinteractivity-component branch 2 times, most recently from febcb3e to a2b9378 Compare October 27, 2023 16:17
alexandredamiron
alexandredamiron suggested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@alexandredamiron alexandredamiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a warning non present in dev

Capture d’écran 2023-10-30 à 15 56 48

clarani
clarani reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments

@anisometropie anisometropie force-pushed the sba/front/ts-migration-enableinteractivity-component branch from bb02c51 to 158a0bb Compare October 31, 2023 12:40
@anisometropie
Copy link
Contributor Author

anisometropie commented Oct 31, 2023 •
edited
Loading

done @alexandredamiron

I've got a warning non present in dev

Capture d’écran 2023-10-30 à 15 56 48

clarani
clarani reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find a small bug on the SpaceTimeChart while testing

@anisometropie anisometropie force-pushed the sba/front/ts-migration-enableinteractivity-component branch from 158a0bb to e7e92a3 Compare November 6, 2023 13:27
clarani
clarani approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the bug is solved ! Nice job 🎉

@anisometropie anisometropie added this pull request to the merge queue Nov 7, 2023
Merged via the queue into dev with commit 1e60c48 Nov 7, 2023
@anisometropie anisometropie deleted the sba/front/ts-migration-enableinteractivity-component branch November 7, 2023 10:25
@flomonster flomonster changed the title enableinteractivity Migrate enableinteractivity to typescript Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandredamiron alexandredamiron alexandredamiron approved these changes

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: migrate enableInteractivity to typescript
4 participants
@anisometropie @alexandredamiron @clarani @SarahBellaha