Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix cursor position on space time chart on mouse move #5271

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 10, 2023

closes #5246

@clarani clarani requested a review from a team as a code owner October 10, 2023 09:36
@clarani clarani added the area:front Work on Standard OSRD Interface modules label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #5271 (6912013) into dev (093127c) will increase coverage by 0.03%.
Report is 5 commits behind head on dev.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #5271      +/-   ##
============================================
+ Coverage     18.63%   18.67%   +0.03%     
  Complexity     2318     2318              
============================================
  Files           855      856       +1     
  Lines        104107   103917     -190     
  Branches       2408     2409       +1     
============================================
+ Hits          19399    19405       +6     
+ Misses        83368    83171     -197     
- Partials       1340     1341       +1     
Flag Coverage Δ
front 7.05% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ult/components/SpeedSpaceChart/SpeedSpaceChart.tsx 0.00% <ø> (ø)
...esult/components/SpaceTimeChart/SpaceTimeChart.tsx 0.00% <0.00%> (ø)
...s/trainschedule/components/Timetable/Timetable.tsx 0.00% <0.00%> (ø)
...lt/components/ChartHelpers/enableInteractivity.jsx 0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes

@kmer2016
Copy link
Contributor

Well done !

@clarani clarani added this pull request to the merge queue Oct 10, 2023
Merged via the queue into dev with commit bd10ae1 Oct 10, 2023
@clarani clarani deleted the cni-5246-fix-get branch October 10, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating dot in space-time chart after dragging a train
3 participants