Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: return directly core's internal error #5296

Merged
merged 1 commit into from
Oct 12, 2023
Merged

editoast: return directly core's internal error #5296

merged 1 commit into from
Oct 12, 2023

Conversation

ElysaSrc
Copy link
Member

@ElysaSrc ElysaSrc commented Oct 11, 2023 •
edited
Loading

Fixes #5244

@ElysaSrc ElysaSrc requested a review from a team as a code owner October 11, 2023 21:25
@ElysaSrc ElysaSrc marked this pull request as draft October 12, 2023 07:32
@ElysaSrc ElysaSrc changed the title draft: editoast: return directly core's internal error editoast: return directly core's internal error Oct 12, 2023
@ElysaSrc ElysaSrc force-pushed the ev/preserve-internal-errors-ctx branch from 5302b0e to 58acbc4 Compare October 12, 2023 07:51
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #5296 (97f0a8f) into dev (6d21dd0) will increase coverage by 0.00%.
Report is 3 commits behind head on dev.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev    #5296   +/-   ##
=========================================
  Coverage     18.75%   18.75%           
  Complexity     2318     2318           
=========================================
  Files           852      852           
  Lines        103447   103452    +5     
  Branches       2402     2402           
=========================================
+ Hits          19397    19398    +1     
- Misses        82710    82714    +4     
  Partials       1340     1340
Flag Coverage Δ
editoast 69.94% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
editoast/src/error.rs 25.80% <0.00%> (-0.87%) ⬇️
editoast/src/core/mod.rs 43.29% <0.00%> (-1.39%) ⬇️

... and 1 file with indirect coverage changes

@ElysaSrc ElysaSrc force-pushed the ev/preserve-internal-errors-ctx branch from 58acbc4 to 64e2c5f Compare October 12, 2023 09:26
@ElysaSrc ElysaSrc marked this pull request as ready for review October 12, 2023 09:26
@ElysaSrc ElysaSrc force-pushed the ev/preserve-internal-errors-ctx branch from 64e2c5f to 97f0a8f Compare October 12, 2023 09:28
eckter
eckter approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the code, but I've tested and the errors are properly forwarded

leovalais
leovalais approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code lgtm, thanks @eckter for testing!

@ElysaSrc ElysaSrc added this pull request to the merge queue Oct 12, 2023
Merged via the queue into dev with commit a6370f8 Oct 12, 2023
@ElysaSrc ElysaSrc deleted the ev/preserve-internal-errors-ctx branch October 12, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eckter eckter eckter approved these changes

@leovalais leovalais leovalais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

editoast: core errors are forwarded with very little context
3 participants
@ElysaSrc @eckter @leovalais