Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: refacto timetable component #5319

Merged
merged 1 commit into from
Oct 31, 2023
Merged

front: refacto timetable component #5319

merged 1 commit into from
Oct 31, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 12, 2023 •
edited
Loading

closes #5215
closes #4898

@clarani clarani requested review from a team as code owners October 12, 2023 14:42
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #5319 (3e1e1b3) into dev (a6d0b36) will increase coverage by 0.00%.
Report is 1 commits behind head on dev.
The diff coverage is 3.14%.

@@            Coverage Diff            @@
##                dev    #5319   +/-   ##
=========================================
  Coverage     19.46%   19.47%           
  Complexity     2320     2320           
=========================================
  Files           871      871           
  Lines        104803   104716   -87     
  Branches       2538     2537    -1     
=========================================
- Hits          20402    20394    -8     
+ Misses        82927    82849   -78     
+ Partials       1474     1473    -1
Flag Coverage Δ
editoast 68.00% <ø> (-0.03%) ⬇️
front 8.08% <3.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ront/src/applications/operationalStudies/consts.ts 78.11% <100.00%> (ø)
front/src/common/api/osrdEditoastApi.ts 91.88% <100.00%> (ø)
...ionResult/components/SpeedSpaceChart/sampleData.ts 0.00% <ø> (ø)
...ationResult/components/simulationResultsHelpers.ts 36.47% <ø> (+0.10%) ⬆️
front/src/reducers/osrdconf/index.ts 33.14% <100.00%> (ø)
front/src/reducers/osrdconf2/common/index.ts 81.29% <100.00%> (ø)
front/src/reducers/osrdsimulation/actions.ts 27.17% <ø> (+0.61%) ⬆️
front/src/reducers/osrdsimulation/index.ts 51.28% <ø> (+0.28%) ⬆️
front/src/reducers/osrdsimulation/selectors.ts 0.00% <ø> (ø)
front/src/reducers/osrdsimulation/types.ts 99.61% <ø> (-0.01%) ⬇️
... and 9 more

... and 2 files with indirect coverage changes

@clarani clarani force-pushed the cni-5215-clean-timetable branch 2 times, most recently from d4988b8 to e437448 Compare October 13, 2023 09:04
leovalais
leovalais approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenApi changes

Akctarus
Akctarus approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local, LGTM, nice refacto :)

@SharglutDev
Copy link
Contributor

Just started the review and while testing I have this white screen when adding a train and going to "simulation parameters" tab :/

image

SharglutDev
SharglutDev requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refacto ! Left some comments :)

@clarani clarani force-pushed the cni-5215-clean-timetable branch from e437448 to 428c17b Compare October 24, 2023 12:44
SharglutDev
SharglutDev approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, tested in local. First error is gone as well after the rebase.

@clarani clarani force-pushed the cni-5215-clean-timetable branch from 5e3bfc6 to 48edb16 Compare October 26, 2023 14:12
@clarani clarani enabled auto-merge October 30, 2023 11:10
@clarani clarani added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2023
@clarani clarani added this pull request to the merge queue Oct 30, 2023
@clarani clarani removed this pull request from the merge queue due to a manual request Oct 30, 2023
@clarani clarani force-pushed the cni-5215-clean-timetable branch from 48edb16 to 9736af4 Compare October 31, 2023 11:22
@clarani clarani enabled auto-merge October 31, 2023 11:22
@clarani clarani force-pushed the cni-5215-clean-timetable branch from 9736af4 to 3e1e1b3 Compare October 31, 2023 14:54
@clarani clarani added this pull request to the merge queue Oct 31, 2023
Merged via the queue into dev with commit 84486d8 Oct 31, 2023
@clarani clarani deleted the cni-5215-clean-timetable branch October 31, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovalais leovalais leovalais approved these changes

@anisometropie anisometropie anisometropie approved these changes

@Math-R Math-R Math-R approved these changes

@Akctarus Akctarus Akctarus approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@clarani @SharglutDev @leovalais @anisometropie @Math-R @Akctarus