-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: add endpoint to retrieve electrical profiles along a path #5328
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5328 +/- ##
============================================
+ Coverage 18.84% 18.89% +0.04%
Complexity 2315 2315
============================================
Files 851 854 +3
Lines 102677 102756 +79
Branches 2403 2403
============================================
+ Hits 19346 19411 +65
- Misses 81990 82004 +14
Partials 1341 1341
Flags with carried forward coverage won't be shown. Click here to find out more.
|
01f52c2
to
feccacc
Compare
feccacc
to
9a9fb82
Compare
In order to reuse most of the code in other similar views
9a9fb82
to
254c529
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR can be reviewed commit by commit.
The first commit refactors the
catenaries_on_path
endpoint so that the functions can be reused for the new and very similar endpoint.The second adds said endpoint.