Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add endpoint to retrieve electrical profiles along a path #5328

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Oct 12, 2023

This PR can be reviewed commit by commit.

The first commit refactors the catenaries_on_path endpoint so that the functions can be reused for the new and very similar endpoint.
The second adds said endpoint.

@Castavo Castavo requested review from a team as code owners October 12, 2023 17:00
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #5328 (254c529) into dev (ad4ac05) will increase coverage by 0.04%.
Report is 6 commits behind head on dev.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##                dev    #5328      +/-   ##
============================================
+ Coverage     18.84%   18.89%   +0.04%     
  Complexity     2315     2315              
============================================
  Files           851      854       +3     
  Lines        102677   102756      +79     
  Branches       2403     2403              
============================================
+ Hits          19346    19411      +65     
- Misses        81990    82004      +14     
  Partials       1341     1341              
Flag Coverage Δ
editoast 69.69% <92.85%> (+0.13%) ⬆️
front 7.17% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
editoast/osrd_containers/src/rangemap_utils.rs 100.00% <100.00%> (ø)
editoast/src/converters/utils.rs 88.07% <100.00%> (ø)
editoast/src/infra_cache/mod.rs 76.58% <ø> (ø)
editoast/src/models/pathfinding.rs 100.00% <ø> (ø)
...st/src/models/rolling_stock/light_rolling_stock.rs 100.00% <ø> (ø)
editoast/src/schema/mod.rs 94.52% <100.00%> (+0.49%) ⬆️
editoast/src/schema/route.rs 98.18% <100.00%> (ø)
editoast/src/views/infra/pathfinding.rs 76.19% <100.00%> (ø)
editoast/src/views/mod.rs 98.46% <100.00%> (+0.02%) ⬆️
editoast/src/views/pathfinding/catenaries.rs 97.50% <100.00%> (-1.33%) ⬇️
... and 7 more

... and 2 files with indirect coverage changes

@Castavo Castavo requested review from flomonster and clarani October 12, 2023 17:05
@Castavo Castavo force-pushed the bpt/editoast/electrical-profiles-on-path branch from 01f52c2 to feccacc Compare October 12, 2023 17:17
@Castavo Castavo force-pushed the bpt/editoast/electrical-profiles-on-path branch from feccacc to 9a9fb82 Compare October 20, 2023 07:36
@Castavo Castavo self-assigned this Oct 20, 2023
@Castavo Castavo force-pushed the bpt/editoast/electrical-profiles-on-path branch from 9a9fb82 to 254c529 Compare October 20, 2023 13:49
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✔️

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Castavo Castavo added this pull request to the merge queue Oct 23, 2023
Merged via the queue into dev with commit 6e4a035 Oct 23, 2023
@Castavo Castavo deleted the bpt/editoast/electrical-profiles-on-path branch October 23, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants