font: display kps

[nicolaswurtz]

Close #5222

It should display KP on all maps for:

• detectors
• bufferstops
• signals
• psl signs (broken on angle)

Operational points kps should be displayed when backend will be updated.

[codecov]

Codecov Report

Merging #5402 (7246a6c) into dev (f7fe126) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #5402      +/-   ##
============================================
- Coverage     18.77%   18.74%   -0.03%     
  Complexity     2317     2317              
============================================
  Files           856      857       +1     
  Lines        103023   103177     +154     
  Branches       2403     2404       +1     
============================================
  Hits          19344    19344              
- Misses        82338    82491     +153     
- Partials       1341     1342       +1     

Flag	Coverage Δ
front	7.10% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
front/src/common/Map/Settings/MapSettings.tsx	0.00% <ø> (ø)
...src/common/Map/Layers/extensions/SNCF/SNCF_PSL.tsx	0.00% <0.00%> (ø)
front/src/common/Map/Layers/Detectors.tsx	0.00% <0.00%> (ø)
...ont/src/common/Map/Settings/MapSettingsSignals.tsx	0.00% <0.00%> (ø)
front/src/common/Map/Layers/BufferStops.tsx	0.00% <0.00%> (ø)
front/src/common/Map/Layers/Signals.tsx	0.00% <0.00%> (ø)
...mmon/Map/Layers/extensions/SNCF/SNCF_PSL_SIGNS.tsx	0.00% <0.00%> (ø)
front/src/common/Map/Layers/GeoJSONs.tsx	0.00% <0.00%> (ø)
...ront/src/common/Map/Settings/MapSettingsLayers.tsx	0.00% <0.00%> (ø)
front/src/common/Map/Layers/OperationalPoints.tsx	0.00% <0.00%> (ø)
... and 2 more

[sim51]

Is it useful to have them at this level of zoom ?

Should we have the PK also on the editor ?

[SharglutDev]

Tested in local and it seems that even when the signals layer is disabled, the PK from the signal is still displayed.

[nicolaswurtz]

Is it useful to have them at this level of zoom ?

Should we have the PK also on the editor ?

Corrected !

[nicolaswurtz]

Tested in local and it seems that even when the signals layer is disabled, the PK from the signal is still displayed.

corrected

[SharglutDev]

Lgtm, nice feature !

[sim51]

You replaced the map item's label (generally the item's ID) for Detector & BufferStop by the KP value.

For me (as a not rails guy), it was hard to figure out that the label is the KP and not the ID/name of the object.
Can we prefix the value by KP ?

Moreover on signals, KPs are displayed just under the signal name. So there is 2 ways of how a KP is displayed on the map.

[nicolaswurtz]

You replaced the map item's label (generally the item's ID) for Detector & BufferStop by the KP value.
For me (as a not rails guy), it was hard to figure out that the label is the KP and not the ID/name of the object. Can we prefix the value by KP ?

As the KP becomes a label "KP" mention is useless because it's firstly a label.

Moreover on signals, KPs are displayed just under the signal name. So there is 2 ways of how a KP is displayed on the map.

KPs are centered under centered signals, lefted or righted along signal's position.

[sim51]

As discussed with @nicolaswurtz :

• KP as label makes sense for rails expert (also without the KP prefix).
• There is a general bug of signals, so my comment on the 'stops' is not linked to this PR