Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix operational point layer #5420

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix operational point layer #5420

merged 1 commit into from
Oct 20, 2023

Conversation

flomonster
Copy link
Contributor

Adapt geometry from multipoint into point

@flomonster flomonster requested a review from a team as a code owner October 20, 2023 14:48
younesschrifi
younesschrifi approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

leovalais
leovalais approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the code, but that representation seems a bit shaky to me. OPs are physical objects that have a not negligible ground area. We might want to intersect it with something else for instance.

@flomonster flomonster requested a review from leovalais October 20, 2023 15:09
@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #5420 (fc0f94b) into dev (0731aaf) will decrease coverage by 0.01%.
Report is 1 commits behind head on dev.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #5420      +/-   ##
============================================
- Coverage     18.84%   18.83%   -0.01%     
  Complexity     2315     2315              
============================================
  Files           851      851              
  Lines        102677   102682       +5     
  Branches       2403     2403              
============================================
- Hits          19347    19345       -2     
- Misses        81989    81996       +7     
  Partials       1341     1341
Flag Coverage Δ
editoast 69.54% <ø> (-0.03%) ⬇️
front 7.15% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
front/src/common/api/osrdEditoastApi.ts 91.95% <100.00%> (ø)

... and 3 files with indirect coverage changes

@flomonster flomonster force-pushed the fam/fix-op-layer branch 2 times, most recently from 1347cf5 to 2da9e89 Compare October 20, 2023 16:13
@flomonster
editoast: fix operational point layer
fc0f94b 
- Adapt geometry from multipoint into point
- Add the kp feature to the layer configuration
@flomonster flomonster merged commit f1fc4d4 into dev Oct 20, 2023
@flomonster flomonster deleted the fam/fix-op-layer branch October 20, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khoyo Khoyo Khoyo approved these changes

@leovalais leovalais leovalais approved these changes

@younesschrifi younesschrifi younesschrifi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flomonster @Khoyo @leovalais @younesschrifi