Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: update selected projection after train deletion #5438

Merged
merged 2 commits into from
Nov 13, 2023
Merged

front: update selected projection after train deletion #5438

merged 2 commits into from
Nov 13, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 23, 2023

closes #5403

@clarani clarani requested a review from a team as a code owner October 23, 2023 16:08
@clarani clarani added the area:front Work on Standard OSRD Interface modules label Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

Merging #5438 (c170adb) into dev (7306be6) will decrease coverage by 0.02%.
Report is 3 commits behind head on dev.
The diff coverage is 2.71%.

@@             Coverage Diff              @@
##                dev    #5438      +/-   ##
============================================
- Coverage     19.58%   19.57%   -0.02%     
  Complexity     2322     2322              
============================================
  Files           886      886              
  Lines        105754   105819      +65     
  Branches       2572     2572              
============================================
+ Hits          20714    20715       +1     
- Misses        83531    83595      +64     
  Partials       1509     1509
Flag Coverage Δ
front 8.30% <2.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
front/src/reducers/osrdsimulation/types.ts 99.61% <100.00%> (+<0.01%) ⬆️
front/src/utils/array.ts 73.91% <ø> (+3.07%) ⬆️
...ult/components/SpeedSpaceChart/SpeedSpaceChart.tsx 0.00% <0.00%> (ø)
...nResult/components/SimulationResultsMap/helpers.ts 48.36% <0.00%> (-1.30%) ⬇️
...geTrainSchedule/SubmitConfUpdateTrainSchedules.tsx 0.00% <0.00%> (ø)
...hedule/components/Timetable/TimetableTrainCard.tsx 0.00% <0.00%> (ø)
...onents/DriverTrainSchedule/DriverTrainSchedule.tsx 0.00% <0.00%> (ø)
.../components/SpeedSpaceChart/SpeedSpaceSettings.tsx 0.00% <0.00%> (ø)
...s/trainschedule/components/Timetable/Timetable.tsx 0.00% <0.00%> (ø)
...ons/operationalStudies/views/SimulationResults.tsx 0.00% <0.00%> (ø)
... and 2 more

Akctarus
Akctarus approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SharglutDev
SharglutDev requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR ! Left two comments.

Tested and it works if the remaining train has a different path, it gets the projection.

But if we have 3 trains, 2 with same path and one different, if we delete one of the "common path" train, the projection isn't set on any train in the list.

@clarani clarani force-pushed the cni-5403-modify-selected-projection branch 2 times, most recently from d2cd3e3 to 66e799b Compare October 27, 2023 08:42
@clarani clarani force-pushed the cni-5403-modify-selected-projection branch from 66e799b to c2a55a0 Compare November 2, 2023 10:10
@Akctarus Akctarus self-requested a review November 2, 2023 15:03
@clarani clarani force-pushed the cni-5403-modify-selected-projection branch from c2a55a0 to 5619e6f Compare November 3, 2023 13:30
@clarani clarani force-pushed the cni-5403-modify-selected-projection branch from 5619e6f to af7c368 Compare November 10, 2023 17:02
SharglutDev
SharglutDev approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, tested in local, very nice job :)

@clarani clarani force-pushed the cni-5403-modify-selected-projection branch from 529467b to c170adb Compare November 13, 2023 10:49
nicolaswurtz
nicolaswurtz approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@nicolaswurtz nicolaswurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@clarani clarani added this pull request to the merge queue Nov 13, 2023
Merged via the queue into dev with commit 0de0f5b Nov 13, 2023
@clarani clarani deleted the cni-5403-modify-selected-projection branch November 13, 2023 13:33
Akctarus
Akctarus approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local, LGTM

@clarani clarani mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

@Akctarus Akctarus Akctarus approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: projection is not updated when a train is deleted from the list
4 participants
@clarani @nicolaswurtz @Akctarus @SharglutDev