core: improve argument parsing #5445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
multun
commented
Oct 24, 2023
•
multun
commented
- Allow all parameters to be set using environment variables starting with CORE_
- Rename MIDDLEWARE_BASE_URL to CORE_EDITOAST_URL
- Rename FETCH_INFRA_AUTHORIZATION to CORE_EDITOAST_AUTHORIZATION
- Rename SENTRY_DSN to CORE_SENTRY_DSN
- Rename OSRD_API_THREADS to CORE_THREADS
multun
force-pushed
the
core-arg-parsing
branch
from
1217116 to
c13e507
Compare
Codecov Report
@@ Coverage Diff @@
## dev #5445 +/- ##
============================================
- Coverage 18.89% 18.88% -0.01%
Complexity 2315 2315
============================================
Files 854 855 +1
Lines 102770 102775 +5
Branches 2403 2402 -1
============================================
Hits 19414 19414
- Misses 82015 82020 +5
Partials 1341 1341
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Khoyo
approved these changes
Oct 24, 2023
- Allow all parameters to be set using environment variables starting with CORE_ - Rename MIDDLEWARE_BASE_URL to CORE_EDITOAST_URL - Rename FETCH_INFRA_AUTHORIZATION to CORE_EDITOAST_AUTHORIZATION - Rename SENTRY_DSN to CORE_SENTRY_DSN - Rename OSRD_API_THREADS to CORE_THREADS
multun
force-pushed
the
core-arg-parsing
branch
from
c13e507 to
d1ff2dd
Compare
eckter
approved these changes
Oct 24, 2023
Erashin
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.