front: fix study dates

[Akctarus]

closes #5479 for the front part

[codecov]

Codecov Report

Merging #5501 (c4acd64) into dev (1bfe9fd) will decrease coverage by 0.01%.
The diff coverage is 9.83%.

@@             Coverage Diff              @@
##                dev    #5501      +/-   ##
============================================
- Coverage     19.60%   19.60%   -0.01%     
  Complexity     2322     2322              
============================================
  Files           885      886       +1     
  Lines        105755   105787      +32     
  Branches       2571     2572       +1     
============================================
+ Hits          20731    20735       +4     
- Misses        83516    83543      +27     
- Partials       1508     1509       +1     

Flag	Coverage Δ
front	8.34% <9.83%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
front/src/common/BootstrapSNCF/InputSNCF.tsx	25.27% <100.00%> (ø)
front/src/utils/date.ts	59.37% <36.36%> (-12.06%)	⬇️
...c/modules/study/components/AddOrEditStudyModal.tsx	0.00% <0.00%> (ø)
front/src/modules/study/utils.ts	0.00% <0.00%> (ø)

[SarahBellaha]

LGTM :)
Just left a tiny suggestion

[SharglutDev]

Tested in local, left a suggestion to simplify the code.

According the front guidelines, you could also move this function, the formatDateForInput and createSelectOptions in a utils file in the study folder.

[SharglutDev]

Here both dates are underlined in red but only one is invalid.
I think it should be only the date responsible for the invalidity that gets the red underline

[SharglutDev]

Lgtm, great job :)

[clarani]

LGTM ✅