Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: fix stdcm types #5551

Merged
merged 1 commit into from
Nov 3, 2023
Merged

editoast: fix stdcm types #5551

merged 1 commit into from
Nov 3, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 31, 2023 •
edited
Loading

  • make margin_before, magin_after and standard_allowance nullable
  • make maximum_run_time not nullable
  • fix a comment in core

closes #5546

@clarani clarani added the area:editoast Work on Editoast Service label Oct 31, 2023
@clarani clarani requested review from a team as code owners October 31, 2023 17:24
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #5551 (4d3e463) into dev (b6936d6) will decrease coverage by 0.02%.
Report is 7 commits behind head on dev.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #5551      +/-   ##
============================================
- Coverage     19.49%   19.48%   -0.02%     
  Complexity     2322     2322              
============================================
  Files           878      878              
  Lines        105423   105486      +63     
  Branches       2544     2544              
============================================
- Hits          20556    20553       -3     
- Misses        83386    83452      +66     
  Partials       1481     1481
Flag Coverage Δ
core 78.79% <ø> (ø)
editoast 67.84% <100.00%> (-0.05%) ⬇️
front 8.21% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...main/java/fr/sncf/osrd/api/stdcm/STDCMRequest.java 100.00% <ø> (ø)
editoast/src/views/stdcm/mod.rs 90.81% <100.00%> (ø)
front/src/common/api/osrdEditoastApi.ts 91.88% <100.00%> (ø)

... and 7 files with indirect coverage changes

@clarani clarani force-pushed the cni-5546-fix-stdcm-types-in-editoast branch from a978dd0 to 4e8b053 Compare November 2, 2023 10:35
@clarani clarani requested a review from eckter as a code owner November 2, 2023 10:35
@clarani clarani force-pushed the cni-5546-fix-stdcm-types-in-editoast branch 2 times, most recently from 48a7fe6 to a48be53 Compare November 2, 2023 11:08
flomonster
flomonster approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (review back only). Just one small comment.

@clarani
editoast: fix stdcm types
4d3e463 
- make margin_before, magin_after and standard_allowance nullable
- make maximumu_run_time not nullable
+ fix a comment in core
@clarani clarani force-pushed the cni-5546-fix-stdcm-types-in-editoast branch from a48be53 to 4d3e463 Compare November 3, 2023 15:16
@clarani clarani enabled auto-merge November 3, 2023 15:18
@clarani clarani added this pull request to the merge queue Nov 3, 2023
Merged via the queue into dev with commit 86cf230 Nov 3, 2023
@clarani clarani deleted the cni-5546-fix-stdcm-types-in-editoast branch November 3, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eckter eckter eckter approved these changes

@flomonster flomonster flomonster approved these changes

Assignees
No one assigned
Labels
area:editoast Work on Editoast Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

editoast: types for stdcm are not compatible with front and core definitions
3 participants
@clarani @eckter @flomonster