Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: force apply space occupation rect on eco #5554

Merged
merged 1 commit into from
Nov 16, 2023
Merged

front: force apply space occupation rect on eco #5554

merged 1 commit into from
Nov 16, 2023

Conversation

alexandredamiron
Copy link
Contributor

Closes #5495

@alexandredamiron alexandredamiron requested a review from a team as a code owner November 2, 2023 08:31
@alexandredamiron alexandredamiron added area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management labels Nov 2, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d8a9f7a) 19.62% compared to head (de09d77) 19.62%.
Report is 4 commits behind head on dev.

Files Patch % Lines
...ationResult/components/SpaceTimeChart/drawTrain.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #5554      +/-   ##
============================================
- Coverage     19.62%   19.62%   -0.01%     
  Complexity     2326     2326              
============================================
  Files           886      886              
  Lines        105946   105950       +4     
  Branches       2576     2576              
============================================
  Hits          20788    20788              
- Misses        83649    83653       +4     
  Partials       1509     1509
Flag Coverage Δ
front 8.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SharglutDev
SharglutDev approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, tested in local

image

clarani
clarani approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@alexandredamiron alexandredamiron force-pushed the adn/fixSpaceOccupationOnEco branch from 760cf27 to de09d77 Compare November 16, 2023 14:42
@alexandredamiron alexandredamiron added this pull request to the merge queue Nov 16, 2023
Merged via the queue into dev with commit f56ec6e Nov 16, 2023
@alexandredamiron alexandredamiron deleted the adn/fixSpaceOccupationOnEco branch November 16, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On the Time space diagram, the block occupation should follow the slowest path of a train if there is two.
3 participants
@alexandredamiron @clarani @SharglutDev