Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add error_layers when cloning an infra #5576

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

younesschrifi
Copy link
Contributor

Close #5539

@younesschrifi younesschrifi requested a review from a team as a code owner November 2, 2023 15:34
@younesschrifi younesschrifi requested a review from hamz2a November 2, 2023 15:34
@younesschrifi younesschrifi force-pushed the yci/add-errors-layer-duplication branch from 012ca2d to 44e8d94 Compare November 2, 2023 15:35
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #5576 (0c25f99) into dev (8ecea1c) will increase coverage by 0.00%.
Report is 3 commits behind head on dev.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                dev    #5576   +/-   ##
=========================================
  Coverage     19.49%   19.50%           
  Complexity     2322     2322           
=========================================
  Files           878      878           
  Lines        105423   105428    +5     
  Branches       2544     2544           
=========================================
+ Hits          20555    20559    +4     
- Misses        83387    83388    +1     
  Partials       1481     1481           
Flag Coverage Δ
editoast 67.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
editoast/src/views/infra/mod.rs 98.00% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

@younesschrifi younesschrifi force-pushed the yci/add-errors-layer-duplication branch from 44e8d94 to 53b5950 Compare November 2, 2023 15:57
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamz2a hamz2a closed this Nov 2, 2023
@hamz2a hamz2a reopened this Nov 2, 2023
Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@younesschrifi younesschrifi force-pushed the yci/add-errors-layer-duplication branch from 53b5950 to 0c25f99 Compare November 2, 2023 16:53
@younesschrifi younesschrifi added this pull request to the merge queue Nov 2, 2023
Merged via the queue into dev with commit c39e699 Nov 2, 2023
@younesschrifi younesschrifi deleted the yci/add-errors-layer-duplication branch November 2, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infra duplication doesn't duplicate errors layer
3 participants