core: add a position bound when shifting envelope parts #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #5585 +/- ##
=========================================
Coverage 19.87% 19.87%
Complexity 2122 2122
=========================================
Files 910 910
Lines 108351 108352 +1
Branches 2649 2649
=========================================
+ Hits 21537 21538 +1
Misses 85260 85260
Partials 1554 1554
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Erashin
approved these changes
Nov 8, 2023
multun
suggested changes
Nov 13, 2023
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.java
Outdated
Show resolved
Hide resolved
Khoyo
approved these changes
Nov 16, 2023
multun
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5574