Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: added specific error handling for the not found infra #5631

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Nov 8, 2023

Added specific error handling for the 'not found' infrastructure case in the clone function

@hamz2a hamz2a requested a review from a team as a code owner November 8, 2023 15:58
@hamz2a hamz2a self-assigned this Nov 8, 2023
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #5631 (82e0070) into dev (5c88cf6) will increase coverage by 0.00%.
Report is 1 commits behind head on dev.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                dev    #5631   +/-   ##
=========================================
  Coverage     19.62%   19.62%           
  Complexity     2322     2322           
=========================================
  Files           880      880           
  Lines        105614   105616    +2     
  Branches       2566     2566           
=========================================
+ Hits          20730    20732    +2     
  Misses        83381    83381           
  Partials       1503     1503           
Flag Coverage Δ
editoast 67.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
editoast/src/models/infra.rs 81.60% <100.00%> (+0.43%) ⬆️

... and 2 files with indirect coverage changes

@hamz2a hamz2a force-pushed the hai/editoast-infra-clone-fix branch from 211deb0 to d7536bc Compare November 8, 2023 16:23
@hamz2a hamz2a force-pushed the hai/editoast-infra-clone-fix branch from d7536bc to 82e0070 Compare November 8, 2023 16:24
@hamz2a hamz2a enabled auto-merge November 8, 2023 16:26
@hamz2a hamz2a added this pull request to the merge queue Nov 8, 2023
Merged via the queue into dev with commit f86a14e Nov 8, 2023
@hamz2a hamz2a deleted the hai/editoast-infra-clone-fix branch November 8, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants