Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: study with missing dates are valid #5637

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Nov 9, 2023

Fixes #5560.

@Khoyo Khoyo requested a review from a team as a code owner November 9, 2023 08:47
@Khoyo Khoyo added kind:bug Something isn't working area:editoast Work on Editoast Service labels Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #5637 (db58b6d) into dev (e5075d3) will increase coverage by 0.00%.
The diff coverage is 88.09%.

@@            Coverage Diff            @@
##                dev    #5637   +/-   ##
=========================================
  Coverage     19.61%   19.62%           
  Complexity     2322     2322           
=========================================
  Files           880      880           
  Lines        105594   105610   +16     
  Branches       2566     2566           
=========================================
+ Hits          20715    20727   +12     
- Misses        83376    83380    +4     
  Partials       1503     1503           
Flag Coverage Δ
editoast 67.95% <88.09%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
editoast/src/models/projects.rs 66.21% <90.90%> (+1.93%) ⬆️
editoast/src/models/study.rs 90.32% <81.81%> (-4.92%) ⬇️
editoast/src/views/study.rs 94.18% <90.00%> (+2.51%) ⬆️

... and 3 files with indirect coverage changes

@Khoyo Khoyo added this pull request to the merge queue Nov 9, 2023
Merged via the queue into dev with commit 2c0d7a4 Nov 9, 2023
@Khoyo Khoyo deleted the yk/fix-study-no-date branch November 9, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Study creation error when entering only starting date
2 participants