Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: replace NoTrainIdError by an empty list #5667

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

younesschrifi
Copy link
Contributor

close #5448

@younesschrifi younesschrifi requested a review from a team as a code owner November 13, 2023 15:39
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there no front-end modifications to make? Maybe a unit test would be good

Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0de0f5b) 19.57% compared to head (8ccaf9b) 19.59%.
Report is 5 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5667      +/-   ##
============================================
+ Coverage     19.57%   19.59%   +0.01%     
  Complexity     2322     2322              
============================================
  Files           886      886              
  Lines        105832   105827       -5     
  Branches       2572     2572              
============================================
+ Hits          20716    20736      +20     
+ Misses        83607    83582      -25     
  Partials       1509     1509              
Flag Coverage Δ
editoast 68.38% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/fix-stdcm-display-get branch from d909005 to 936b330 Compare November 13, 2023 16:53
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@younesschrifi younesschrifi force-pushed the yci/fix-stdcm-display-get branch from 936b330 to 8ccaf9b Compare November 14, 2023 09:38
@younesschrifi younesschrifi added this pull request to the merge queue Nov 14, 2023
Merged via the queue into dev with commit 6a77c5c Nov 14, 2023
@younesschrifi younesschrifi deleted the yci/fix-stdcm-display-get branch November 14, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: scheduling a train in an empty timetable doesn't show any result
3 participants