-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: replace NoTrainIdError by an empty list #5667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is there no front-end modifications to make? Maybe a unit test would be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #5667 +/- ##
============================================
+ Coverage 19.57% 19.59% +0.01%
Complexity 2322 2322
============================================
Files 886 886
Lines 105832 105827 -5
Branches 2572 2572
============================================
+ Hits 20716 20736 +20
+ Misses 83607 83582 -25
Partials 1509 1509
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d909005
to
936b330
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
936b330
to
8ccaf9b
Compare
close #5448