editoast: rename assert_editoast_error_type macro #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #5674 +/- ##
============================================
- Coverage 19.59% 19.59% -0.01%
Complexity 2322 2322
============================================
Files 886 886
Lines 105816 105816
Branches 2573 2573
============================================
- Hits 20736 20733 -3
- Misses 83570 83573 +3
Partials 1510 1510
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hamz2a
requested review from
flomonster,
Castavo and
leovalais
and removed request for
flomonster
flomonster
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the name of the
assert_editoast_error_typemacro toassert_response_error_type_matchto make it clearer. This macro checks if the type field in the response matches the type field in the providedInternalError.