-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix layers order on map and map performances #5684
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5684 +/- ##
============================================
- Coverage 19.45% 19.45% -0.01%
Complexity 2326 2326
============================================
Files 907 907
Lines 106876 106890 +14
Branches 2579 2579
============================================
Hits 20796 20796
- Misses 84568 84582 +14
Partials 1512 1512
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0243982
to
b9c9479
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Works like magic!
b9c9479
to
a2e89b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice job, the carto is way faster now, thanks 🙏 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good investigation, thx !
close #4872
close #5619
close #5392
The fix for 4872 is the one used for this closed PR.
When 3D relief scale is at 0 (default), the terrain is at undefined and we can see the tracks.
If the scale is higher than 0, they go back under the relief.