Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layers order on map and map performances #5684

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Nov 14, 2023

close #4872
close #5619
close #5392

The fix for 4872 is the one used for this closed PR.
When 3D relief scale is at 0 (default), the terrain is at undefined and we can see the tracks.

image

If the scale is higher than 0, they go back under the relief.

image

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (7664b23) 19.45% compared to head (a2e89b3) 19.45%.

Files Patch % Lines
front/src/applications/referenceMap/Map.tsx 0.00% 6 Missing ⚠️
front/src/applications/editor/Map.tsx 0.00% 5 Missing ⚠️
...mulationResult/components/SimulationResultsMap.tsx 0.00% 5 Missing ⚠️
...ainschedule/components/ManageTrainSchedule/Map.tsx 0.00% 5 Missing ⚠️
front/src/common/Map/Layers/Platforms.tsx 0.00% 2 Missing ⚠️
front/src/common/Map/Consts/colors.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5684      +/-   ##
============================================
- Coverage     19.45%   19.45%   -0.01%     
  Complexity     2326     2326              
============================================
  Files           907      907              
  Lines        106876   106890      +14     
  Branches       2579     2579              
============================================
  Hits          20796    20796              
- Misses        84568    84582      +14     
  Partials       1512     1512              
Flag Coverage Δ
front 8.32% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/fix-platform-over-tracks branch from 0243982 to b9c9479 Compare November 15, 2023 14:00
@SharglutDev SharglutDev marked this pull request as ready for review November 15, 2023 14:01
@SharglutDev SharglutDev requested a review from a team as a code owner November 15, 2023 14:01
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works like magic!

@flomonster flomonster changed the title front: fix layers order on map Fix layers order on map and map performances Nov 17, 2023
@flomonster flomonster force-pushed the pfn/front/fix-platform-over-tracks branch from b9c9479 to a2e89b3 Compare November 17, 2023 14:41
@flomonster flomonster mentioned this pull request Nov 17, 2023
1 task
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice job, the carto is way faster now, thanks 🙏 🚀

Copy link
Contributor

@nicolaswurtz nicolaswurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good investigation, thx !

@nicolaswurtz nicolaswurtz added this pull request to the merge queue Nov 20, 2023
Merged via the queue into dev with commit a87cfd1 Nov 20, 2023
@nicolaswurtz nicolaswurtz deleted the pfn/front/fix-platform-over-tracks branch November 20, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants