Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: infra: ignore 0-length ranges when building zones #5721

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Nov 16, 2023

In the previous version, when the end detector was placed precisely at a transition between two tracks, we would add the chunk that starts there.

Fixes #5535

@eckter eckter requested a review from a team as a code owner November 16, 2023 15:11
@eckter eckter requested a review from Khoyo November 16, 2023 15:11
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d8a9f7a) 19.62% compared to head (dea3062) 19.62%.
Report is 4 commits behind head on dev.

Files Patch % Lines
...kotlin/fr/sncf/osrd/sim_infra/impl/DebugViewers.kt 0.00% 2 Missing ⚠️
...srd/api/pathfinding/PathfindingBlocksEndpoint.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5721      +/-   ##
============================================
- Coverage     19.62%   19.62%   -0.01%     
  Complexity     2326     2326              
============================================
  Files           886      886              
  Lines        105946   105948       +2     
  Branches       2576     2576              
============================================
  Hits          20788    20788              
- Misses        83649    83651       +2     
  Partials       1509     1509              
Flag Coverage Δ
core 78.72% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter added this pull request to the merge queue Nov 17, 2023
Merged via the queue into dev with commit ef61485 Nov 17, 2023
@eckter eckter deleted the ech/fix-zones branch November 17, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: we sometimes interpolate LineString points outside of the [0, 1] range
2 participants