Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: move Generate and ImportRailjson to infra subcommand #5722

Merged
merged 1 commit into from
Nov 22, 2023
Merged

editoast: move Generate and ImportRailjson to infra subcommand #5722

merged 1 commit into from
Nov 22, 2023

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Nov 16, 2023

closes #5699

@hamz2a hamz2a requested a review from a team as a code owner November 16, 2023 15:13
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (b6b7dcf) 19.53% compared to head (bedb0dd) 19.53%.
Report is 2 commits behind head on dev.

Files Patch % Lines
editoast/src/main.rs 15.38% 44 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                dev    #5722   +/-   ##
=========================================
  Coverage     19.53%   19.53%           
  Complexity     2332     2332           
=========================================
  Files           907      907           
  Lines        106998   107014   +16     
  Branches       2593     2593           
=========================================
+ Hits          20901    20907    +6     
- Misses        84571    84581   +10     
  Partials       1526     1526
Flag Coverage Δ
editoast 68.09% <15.38%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster self-requested a review November 16, 2023 15:27
flomonster
flomonster reviewed Nov 16, 2023
View reviewed changes
@hamz2a hamz2a force-pushed the hai/move-generate-and-import-railjson-to-infra-subcommand branch from dc3dc5f to 310259e Compare November 17, 2023 15:43
@hamz2a hamz2a requested a review from flomonster November 17, 2023 15:44
@hamz2a hamz2a force-pushed the hai/move-generate-and-import-railjson-to-infra-subcommand branch from 310259e to 7ed69d4 Compare November 17, 2023 16:08
flomonster
flomonster requested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A few changes were requested.

leovalais
leovalais requested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I answered on @flomonster comments.

For consistency, also replace the eprintln!s of this file by an Err(CliError...) where appropriate.

LGMT otherwise :)

@hamz2a hamz2a force-pushed the hai/move-generate-and-import-railjson-to-infra-subcommand branch from 7ed69d4 to 3caba0d Compare November 21, 2023 14:45
flomonster
flomonster approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I made some suggestions but overall, it looks good

@hamz2a hamz2a force-pushed the hai/move-generate-and-import-railjson-to-infra-subcommand branch from 3caba0d to bedb0dd Compare November 22, 2023 09:49
leovalais
leovalais approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not tested since my last review.

@hamz2a hamz2a added this pull request to the merge queue Nov 22, 2023
Merged via the queue into dev with commit 51df1a8 Nov 22, 2023
@hamz2a hamz2a deleted the hai/move-generate-and-import-railjson-to-infra-subcommand branch November 22, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

@leovalais leovalais leovalais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

editoast: move Generate and ImportRailjson to infra subcommand
3 participants
@hamz2a @flomonster @leovalais