Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix line search not centering on the map #5731

Merged

Conversation

SarahBellaha
Copy link
Contributor

Closes #5492

@SarahBellaha SarahBellaha requested a review from a team as a code owner November 17, 2023 09:40
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (92904fa) 19.57% compared to head (86d0614) 19.58%.
Report is 6 commits behind head on dev.

Files Patch % Lines
front/src/common/Map/Search/MapSearchLine.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #5731   +/-   ##
=========================================
  Coverage     19.57%   19.58%           
  Complexity     2326     2326           
=========================================
  Files           886      890    +4     
  Lines        106157   106106   -51     
  Branches       2576     2579    +3     
=========================================
- Hits          20777    20776    -1     
+ Misses        83871    83818   -53     
- Partials       1509     1512    +3     
Flag Coverage Δ
front 8.33% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 🙏

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

@SarahBellaha SarahBellaha force-pushed the sba/front/fix-line-search-not-centering-on-the-map branch from 5e64e0b to 86d0614 Compare November 17, 2023 16:11
@SarahBellaha SarahBellaha added this pull request to the merge queue Nov 17, 2023
Merged via the queue into dev with commit c5fb150 Nov 17, 2023
@SarahBellaha SarahBellaha deleted the sba/front/fix-line-search-not-centering-on-the-map branch November 17, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The line search does not center the map on the searched line.
2 participants