Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor - compute track section length on creation #5732

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Nov 17, 2023

Close #3974

I also fixed an other 0 displayed on the editor form (related to #5709) on the length field

@sim51 sim51 requested a review from a team as a code owner November 17, 2023 10:59
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (61a0ebd) 19.45% compared to head (e06a890) 19.45%.

Files Patch % Lines
...rc/applications/editor/tools/trackEdition/tool.tsx 0.00% 6 Missing ⚠️
...components/LinearMetadata/FormLineStringLength.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #5732   +/-   ##
=========================================
  Coverage     19.45%   19.45%           
  Complexity     2327     2327           
=========================================
  Files           907      907           
  Lines        106925   106925           
  Branches       2579     2579           
=========================================
  Hits          20801    20801           
  Misses        84609    84609           
  Partials       1515     1515           
Flag Coverage Δ
front 8.32% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

@clarani clarani added this pull request to the merge queue Nov 20, 2023
Merged via the queue into dev with commit fdd08e7 Nov 20, 2023
@clarani clarani deleted the bsi/issue-3974 branch November 20, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot edit slopes and curves
2 participants